From: Scott Wood <scottwood@freescale.com>
To: avorontsov@ru.mvista.com
Cc: linuxppc-dev@ozlabs.org, Mingkai Hu <Mingkai.hu@freescale.com>
Subject: Re: [PATCH v1] Add support for getting device platform data to I2C device
Date: Thu, 18 Dec 2008 11:20:03 -0600 [thread overview]
Message-ID: <494A8643.1030105@freescale.com> (raw)
In-Reply-To: <20081218165946.GA4029@oksana.dev.rtsoft.ru>
Anton Vorontsov wrote:
> On Thu, Dec 18, 2008 at 10:14:11AM +0800, Mingkai Hu wrote:
>> There is no standard way of getting device platform data from
>> dts file to the I2C device when it's probed. This patch adds
>> a function pointer to the of_modalias_table to get such bindings
>> properties into device's platform data.
>
> Unfortunately this approach leads to inability to make the bindings
> modular.
True, but I think it's fine for now while a better mechanism is worked
out -- especially for things that are mainly used in embedded situations
where modular builds aren't as necessary.
> And the solution that everybody seem to agree with (SPI driver example):
> http://lkml.org/lkml/2008/10/30/393
Hmm, that doesn't seem to allow for any binding mechanism other than
internal and OF, and it seems like it could be done more
straightforwardly by having the modalias point to the OF wrapper, which
then instantiates the core driver.
But the above approach has the distinct advantage of having already been
implemented. :-)
-Scott
next prev parent reply other threads:[~2008-12-18 17:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-18 2:14 [PATCH v1] Add support for getting device platform data to I2C device Mingkai Hu
2008-12-18 16:59 ` Anton Vorontsov
2008-12-18 17:20 ` Scott Wood [this message]
2008-12-18 17:49 ` Anton Vorontsov
2009-01-07 0:55 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=494A8643.1030105@freescale.com \
--to=scottwood@freescale.com \
--cc=Mingkai.hu@freescale.com \
--cc=avorontsov@ru.mvista.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).