From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rv-out-0506.google.com (rv-out-0506.google.com [209.85.198.228]) by ozlabs.org (Postfix) with ESMTP id CCE62DE0DC for ; Sun, 19 Apr 2009 12:42:01 +1000 (EST) Received: by rv-out-0506.google.com with SMTP id f9so1238215rvb.9 for ; Sat, 18 Apr 2009 19:41:59 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <764365e7af2e476e43cd674738e51f13b306979b.1239874968.git.monstr@monstr.eu> <74c0088dfda1816c21914c0a8da0c42908526c5e.1239874968.git.monstr@monstr.eu> <20090417170707.B6C95C4004F@mail150-wa4.bigfish.com> Date: Sat, 18 Apr 2009 19:41:59 -0700 Message-ID: <495563870904181941o5a66126dgb59d8cad2b7a66f2@mail.gmail.com> Subject: Re: [microblaze-uclinux] [PATCH 11/11] microblaze: Kconfig: Enable drivers for Microblaze From: Stephen Neuendorffer To: Grant Likely Content-Type: multipart/alternative; boundary=001636e1fd829f0b0e0467df5b64 Cc: linuxppc-dev , John Linn , linux-kernel@vger.kernel.org, microblaze-uclinux@itee.uq.edu.au List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , --001636e1fd829f0b0e0467df5b64 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit On Fri, Apr 17, 2009 at 10:49 PM, Grant Likely wrote: > On Fri, Apr 17, 2009 at 11:06 AM, Stephen Neuendorffer > wrote: > > > > Can we have XILINX_DRIVERS, please? That way this can also be enabled > > on any architecture that has FPGA peripherals. > > I've thought about this more, and I'd really rather not. The list of > affected drivers is short and is not a large maintenance burden. I > don't think a list of 2 or 3 architecture selects for each driver is > unreasonable. A "XILINX_DRIVERS" config item doesn't really help much > anyway. At any given time one of these drivers may be needed on > another platform. ie. the SystemACE device is present on at least one > non-virtex, non-spartan platform. Which is exactly why having it architecture dependent isn't right... All of these drivers could be needed and used on any OF-based platform. If you have a platform (for instance, a processor connected to an FPGA which has these peripherals in the FPGA) then you should be able to enable these drivers. Just my 2 cents... Steve > > g. > > > > > Steve > > > >> -----Original Message----- > >> From: owner-microblaze-uclinux@itee.uq.edu.au > > [mailto:owner-microblaze-uclinux@itee.uq.edu.au] On > >> Behalf Of monstr@monstr.eu > >> Sent: Thursday, April 16, 2009 2:57 AM > >> To: linux-kernel@vger.kernel.org > >> Cc: microblaze-uclinux@itee.uq.edu.au; Michal Simek > >> Subject: [microblaze-uclinux] [PATCH 11/11] microblaze: Kconfig: > > Enable drivers for Microblaze > >> > >> From: Michal Simek > >> > >> Signed-off-by: Michal Simek > >> --- > >> drivers/block/Kconfig | 2 +- > >> drivers/char/Kconfig | 2 +- > >> drivers/gpio/Kconfig | 2 +- > >> drivers/usb/Kconfig | 1 + > >> 4 files changed, 4 insertions(+), 3 deletions(-) > >> > >> diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig > >> index ddea8e4..9f1665f 100644 > >> --- a/drivers/block/Kconfig > >> +++ b/drivers/block/Kconfig > >> @@ -438,7 +438,7 @@ source "drivers/s390/block/Kconfig" > >> > >> config XILINX_SYSACE > >> tristate "Xilinx SystemACE support" > >> - depends on 4xx > >> + depends on 4xx || MICROBLAZE > >> help > >> Include support for the Xilinx SystemACE CompactFlash > > interface > >> > >> diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig > >> index 735bbe2..bb1a071 100644 > >> --- a/drivers/char/Kconfig > >> +++ b/drivers/char/Kconfig > >> @@ -893,7 +893,7 @@ config DTLK > >> > >> config XILINX_HWICAP > >> tristate "Xilinx HWICAP Support" > >> - depends on XILINX_VIRTEX > >> + depends on XILINX_VIRTEX || MICROBLAZE > >> help > >> This option enables support for Xilinx Internal Configuration > >> Access Port (ICAP) driver. The ICAP is used on Xilinx Virtex > >> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig > >> index edb0253..11f3739 100644 > >> --- a/drivers/gpio/Kconfig > >> +++ b/drivers/gpio/Kconfig > >> @@ -69,7 +69,7 @@ comment "Memory mapped GPIO expanders:" > >> > >> config GPIO_XILINX > >> bool "Xilinx GPIO support" > >> - depends on PPC_OF > >> + depends on PPC_OF || MICROBLAZE > >> help > >> Say yes here to support the Xilinx FPGA GPIO device > >> > >> diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig > >> index c6c816b..5eee3f8 100644 > >> --- a/drivers/usb/Kconfig > >> +++ b/drivers/usb/Kconfig > >> @@ -22,6 +22,7 @@ config USB_ARCH_HAS_HCD > >> default y if PCMCIA && !M32R # sl811_cs > >> default y if ARM # SL-811 > >> default y if SUPERH # r8a66597-hcd > >> + default y if MICROBLAZE > >> default PCI > >> > >> # many non-PCI SOC chips embed OHCI > >> -- > >> 1.5.5.1 > >> > >> ___________________________ > >> microblaze-uclinux mailing list > >> microblaze-uclinux@itee.uq.edu.au > >> Project Home Page : > > http://www.itee.uq.edu.au/~jwilliams/mblaze-uclinux > >> Mailing List Archive : > > http://www.itee.uq.edu.au/~listarch/microblaze-uclinux/ > >> > > > > > > This email and any attachments are intended for the sole use of the named > recipient(s) and contain(s) confidential information that may be > proprietary, privileged or copyrighted under applicable law. If you are not > the intended recipient, do not read, copy, or forward this email message or > any attachments. Delete this email message and any attachments immediately. > > > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" > in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > Please read the FAQ at http://www.tux.org/lkml/ > > > > > > -- > Grant Likely, B.Sc., P.Eng. > Secret Lab Technologies Ltd. > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@ozlabs.org > https://ozlabs.org/mailman/listinfo/linuxppc-dev > --001636e1fd829f0b0e0467df5b64 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable

On Fri, Apr 17, 2009 at 10:49 PM, Grant = Likely <g= rant.likely@secretlab.ca> wrote:
On Fri, Apr 17, 2009 at 11:06 AM, Stephen Neuendorffer
<stephen.neuendorffer= @xilinx.com> wrote:
>
> Can we have XILINX_DRIVERS, please? =A0That way this can also be enabl= ed
> on any architecture that has FPGA peripherals.

I've thought about this more, and I'd really rather not. =A0The lis= t of
affected drivers is short and is not a large maintenance burden. =A0I
don't think a list of 2 or 3 architecture selects for each driver is unreasonable. =A0A "XILINX_DRIVERS" config item doesn't reall= y help much
anyway. =A0At any given time one of these drivers may be needed on
another platform. =A0ie. the SystemACE device is present on at least one non-virtex, non-spartan platform.=A0

Which is exactly = why having it architecture dependent isn't right...=A0 All of these dri= vers
could be needed and used on any OF-based platform.=A0 If you have a= platform (for instance, a processor connected to an FPGA which has these p= eripherals in the FPGA) then you should be able to enable these drivers.=A0= Just my 2 cents...

Steve



g.

>
> Steve
>
>> -----Original Message-----
>> From: o= wner-microblaze-uclinux@itee.uq.edu.au
> [mailto:own= er-microblaze-uclinux@itee.uq.edu.au] On
>> Behalf Of monstr@monstr.eu
>> Sent: Thursday, April 16, 2009 2:57 AM
>> To: linux-kernel@v= ger.kernel.org
>> Cc: microblaz= e-uclinux@itee.uq.edu.au; Michal Simek
>> Subject: [microblaze-uclinux] [PATCH 11/11] microblaze: Kconfig: > Enable drivers for Microblaze
>>
>> From: Michal Simek <monstr@monstr.eu>
>>
>> Signed-off-by: Michal Simek <monstr@monstr.eu>
>> ---
>> =A0drivers/block/Kconfig | =A0 =A02 +-
>> =A0drivers/char/Kconfig =A0| =A0 =A02 +-
>> =A0drivers/gpio/Kconfig =A0| =A0 =A02 +-
>> =A0drivers/usb/Kconfig =A0 | =A0 =A01 +
>> =A04 files changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
>> index ddea8e4..9f1665f 100644
>> --- a/drivers/block/Kconfig
>> +++ b/drivers/block/Kconfig
>> @@ -438,7 +438,7 @@ source "drivers/s390/block/Kconfig"<= br> >>
>> =A0config XILINX_SYSACE
>> =A0 =A0 =A0 tristate "Xilinx SystemACE support"
>> - =A0 =A0 depends on 4xx
>> + =A0 =A0 depends on 4xx || MICROBLAZE
>> =A0 =A0 =A0 help
>> =A0 =A0 =A0 =A0 Include support for the Xilinx SystemACE CompactFl= ash
> interface
>>
>> diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
>> index 735bbe2..bb1a071 100644
>> --- a/drivers/char/Kconfig
>> +++ b/drivers/char/Kconfig
>> @@ -893,7 +893,7 @@ config DTLK
>>
>> =A0config XILINX_HWICAP
>> =A0 =A0 =A0 tristate "Xilinx HWICAP Support"
>> - =A0 =A0 depends on XILINX_VIRTEX
>> + =A0 =A0 depends on XILINX_VIRTEX || MICROBLAZE
>> =A0 =A0 =A0 help
>> =A0 =A0 =A0 =A0 This option enables support for Xilinx Internal Co= nfiguration
>> =A0 =A0 =A0 =A0 Access Port (ICAP) driver. =A0The ICAP is used on = Xilinx Virtex
>> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
>> index edb0253..11f3739 100644
>> --- a/drivers/gpio/Kconfig
>> +++ b/drivers/gpio/Kconfig
>> @@ -69,7 +69,7 @@ comment "Memory mapped GPIO expanders:"= ;
>>
>> =A0config GPIO_XILINX
>> =A0 =A0 =A0 bool "Xilinx GPIO support"
>> - =A0 =A0 depends on PPC_OF
>> + =A0 =A0 depends on PPC_OF || MICROBLAZE
>> =A0 =A0 =A0 help
>> =A0 =A0 =A0 =A0 Say yes here to support the Xilinx FPGA GPIO devic= e
>>
>> diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
>> index c6c816b..5eee3f8 100644
>> --- a/drivers/usb/Kconfig
>> +++ b/drivers/usb/Kconfig
>> @@ -22,6 +22,7 @@ config USB_ARCH_HAS_HCD
>> =A0 =A0 =A0 default y if PCMCIA && !M32R =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 =A0# sl811_cs
>> =A0 =A0 =A0 default y if ARM =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 =A0 =A0# SL-811
>> =A0 =A0 =A0 default y if SUPERH =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 =A0 # r8a66597-hcd
>> + =A0 =A0 default y if MICROBLAZE
>> =A0 =A0 =A0 default PCI
>>
>> =A0# many non-PCI SOC chips embed OHCI
>> --
>> 1.5.5.1
>>
>> ___________________________
>> microblaze-uclinux mailing list
>> microblaze-uc= linux@itee.uq.edu.au
>> Project Home Page :
> http://www.itee.uq.edu.au/~jwilliams/mblaze-uclinux
>> Mailing List Archive :
> http://www.itee.uq.edu.au/~listarch/microblaze-uclinux/
>>
>
>
> This email and any attachments are intended for the sole use of the na= med recipient(s) and contain(s) confidential information that may be propri= etary, privileged or copyrighted under applicable law. If you are not the i= ntended recipient, do not read, copy, or forward this email message or any = attachments. Delete this email message and any attachments immediately.
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-k= ernel" in
> the body of a message to = majordomo@vger.kernel.org
> More majordomo info at =A0http://vger.kernel.org/majordomo-info.html=
> Please read the FAQ at =A0http://www.tux.org/lkml/
>



--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

--001636e1fd829f0b0e0467df5b64--