linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: David Gibson <dwg@au1.ibm.com>
Cc: Scott Wood <scottwood@freescale.com>,
	linuxppc-dev@ozlabs.org, Stefan Roese <sr@denx.de>,
	Timur Tabi <timur@freescale.com>
Subject: Re: "cell-index" vs. "index" vs. no index in I2C device nodes
Date: Fri, 6 Jun 2008 04:40:20 +0200	[thread overview]
Message-ID: <49648f3051f1ba1b39e67ec2ce08367c@kernel.crashing.org> (raw)
In-Reply-To: <20080605024140.GA30980@yookeroo.seuss>

>>> From a device tree perspective, index and cell-index are both
>> incorrect.  The IIC macros don't share register blocks with anything,
>> are enumerated as unique instances per macro in the device tree, and
>> should be able to be distinguished by "regs" and/or unit address.
>>
>> Does anyone disagree with that?
>
> Hear, hear.

x2.

> Aliases can also provide a reasonable way of enumerating devices, if
> "reg" isn't suitable on its own.

Yes.  In almost all cases, drivers and subsystems do not need this at
all though.  In OF, one device points to another by putting the phandle
of that pointed-to device in some property (and buses are represented
by their parent bridge).  If the Linux subsystem wants to use an integer
for distinguishing between its various buses, that's fine, but it can
just make up these numbers -- the numbers themselves have no actual
meaning, only the relationships expressed via those numbers do.

In a few cases, particularly where those numbers are user-visible, like
in ethN, the aliases construct is a good solution.  If a 
driver/subsystem
is relying on the aliases though, it should document this in a 
(platform?)
binding -- and it would better have a very good reason for it!


Segher

  reply	other threads:[~2008-06-06  2:41 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-04 15:06 "cell-index" vs. "index" vs. no index in I2C device nodes Stefan Roese
2008-06-04 15:24 ` Timur Tabi
2008-06-04 15:43   ` Scott Wood
2008-06-05  2:19     ` Josh Boyer
2008-06-05  2:41       ` David Gibson
2008-06-06  2:40         ` Segher Boessenkool [this message]
2008-06-06  3:37           ` David Gibson
2008-06-07  0:30             ` Segher Boessenkool
2008-06-06  4:07         ` Grant Likely
2008-06-06  4:29           ` Sean MacLennan
2008-06-05  2:54       ` Sean MacLennan
2008-06-05  3:05         ` Josh Boyer
2008-06-05  3:16           ` Sean MacLennan
2008-06-05  6:22             ` Stefan Roese
2008-06-05  7:48               ` Jean Delvare
2008-06-05  8:45                 ` Stefan Roese
2008-06-05 10:57                   ` David Gibson
2008-06-05 11:52                   ` Josh Boyer
2008-06-05 15:18                     ` Timur Tabi
2008-06-05 22:47                     ` David Gibson
2008-06-06  4:17                   ` Benjamin Herrenschmidt
2008-06-06  4:16                 ` Benjamin Herrenschmidt
2008-06-06  6:21                   ` Jean Delvare
2008-06-06  7:47                     ` Grant Likely
2008-06-06  8:45                     ` Benjamin Herrenschmidt
2008-06-05 15:17               ` Timur Tabi
2008-06-05 15:44                 ` Jochen Friedrich
2008-06-05 15:50                   ` Timur Tabi
2008-06-05 16:10                     ` Grant Likely
2008-06-05 16:18                       ` Timur Tabi
2008-06-05 16:22                         ` Jochen Friedrich
2008-06-05 16:30                           ` Grant Likely
2008-06-05 16:40                             ` Timur Tabi
2008-06-05 22:46                               ` David Gibson
2008-06-05 16:35                         ` Grant Likely
2008-06-05 23:59                     ` Josh Boyer
2008-06-07  0:24                       ` Segher Boessenkool
2008-06-05 21:37               ` Sean MacLennan
2008-06-05 23:48                 ` Josh Boyer
2008-06-05 15:13       ` Timur Tabi
2008-06-05 15:39         ` Grant Likely
2008-06-05 15:43           ` Timur Tabi
2008-06-05 15:52             ` Segher Boessenkool
2008-06-05 16:09               ` Timur Tabi
2008-06-05 16:27                 ` Scott Wood
2008-06-05 17:52                   ` Timur Tabi
2008-06-05 18:04                     ` Scott Wood
2008-06-05 16:00             ` Grant Likely
2008-06-05 16:13               ` Timur Tabi
2008-06-05 16:21                 ` Josh Boyer
2008-06-05 16:25                   ` Timur Tabi
2008-06-05 16:37                     ` Grant Likely
2008-06-05 18:27                     ` Josh Boyer
2008-06-05 18:35                       ` Timur Tabi
2008-06-05 18:40                         ` Josh Boyer
2008-06-05 18:46                       ` Grant Likely
2008-06-05 18:56                         ` Josh Boyer
2008-06-05 19:14                           ` Grant Likely
2008-06-05 19:15                             ` Josh Boyer
2008-06-05 19:16                             ` Timur Tabi
2008-06-05 21:31                               ` Segher Boessenkool
2008-06-05 22:56                               ` David Gibson
2008-06-06 13:09                                 ` Timur Tabi
2008-06-06 13:42                                   ` Stefan Roese
2008-06-05 22:45                             ` Sean MacLennan
2008-06-06  4:20             ` Benjamin Herrenschmidt
2008-06-25 21:46               ` Timur Tabi
2008-06-27 16:48                 ` Jochen Friedrich
2008-06-05 15:46           ` Segher Boessenkool
2008-06-05 15:52           ` Jochen Friedrich
2008-06-05 15:53             ` Grant Likely
2008-06-06  4:19         ` Benjamin Herrenschmidt
2008-06-06  4:14       ` Benjamin Herrenschmidt
2008-06-06  4:13     ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49648f3051f1ba1b39e67ec2ce08367c@kernel.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=dwg@au1.ibm.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=scottwood@freescale.com \
    --cc=sr@denx.de \
    --cc=timur@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).