From: Scott Wood <scottwood@freescale.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 2/5] powerpc: Generic device tree for all AmigaOne boards
Date: Wed, 07 Jan 2009 16:23:53 -0600 [thread overview]
Message-ID: <49652B79.5010502@freescale.com> (raw)
In-Reply-To: <fa686aa40901071421w6c4aa48eyd869eb952373a74d@mail.gmail.com>
Grant Likely wrote:
> On Wed, Jan 7, 2009 at 3:10 PM, Scott Wood <scottwood@freescale.com> wrote:
>> On Wed, Jan 07, 2009 at 09:41:14AM -0700, Grant Likely wrote:
>>>> + 8042@60 {
>>>> + device_type = "8042";
>>>> + reg = <1 0x00000060 0x00000001
>>>> + 1 0x00000064 0x00000001>;
>>>> + // IRQ1, IRQ12 (rising edge)
>>>> + interrupts = <1 3 12 3>;
>>> For the flattened device tree, I think we've settled on the convention
>>> that every node with an IRQ connection should have both the
>>> interrupt-parent and interrupts properties. (ie. don't rely on the
>>> parent node's interrupt-parent property.)
>> Why?
>
> Defensive programming. To not rely on implicit relationships
It doesn't seem any more likely to introduce a fault by specifying the
interrupt controller in one place than in many places.
-Scott
next prev parent reply other threads:[~2009-01-07 22:24 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-07 13:54 [PATCH 1/5] powerpc: Add platform support for AmigaOne Gerhard Pircher
2009-01-07 14:01 ` [PATCH 2/5] powerpc: Generic device tree for all AmigaOne boards Gerhard Pircher
2009-01-07 16:41 ` Grant Likely
2009-01-07 22:10 ` Scott Wood
2009-01-07 22:21 ` Grant Likely
2009-01-07 22:23 ` Scott Wood [this message]
2009-01-07 22:36 ` Grant Likely
2009-01-07 22:38 ` Scott Wood
2009-01-12 5:07 ` Benjamin Herrenschmidt
2009-01-12 5:58 ` Grant Likely
2009-01-07 14:03 ` [PATCH 3/5] powerpc: Bootwrapper and serial console support for AmigaOne Gerhard Pircher
2009-01-07 15:07 ` Grant Likely
2009-01-07 15:20 ` Gerhard Pircher
2009-01-07 15:47 ` Grant Likely
2009-01-07 14:05 ` [PATCH 4/5] powerpc: Default config for AmigaOne boards Gerhard Pircher
2009-01-07 14:12 ` [PATCH 5/5] ide: Force VIA IDE legacy interrupts " Gerhard Pircher
2009-01-07 15:13 ` Grant Likely
2009-01-07 15:27 ` Gerhard Pircher
2009-01-11 16:51 ` Bartlomiej Zolnierkiewicz
2009-01-11 20:05 ` Gerhard Pircher
2009-01-12 17:55 ` Bartlomiej Zolnierkiewicz
2009-01-07 16:07 ` [PATCH 1/5] powerpc: Add platform support for AmigaOne Grant Likely
2009-01-07 19:07 ` Scott Wood
2009-01-07 22:50 ` [PATCH 2/5] powerpc: Generic device tree for all AmigaOne boards Gerhard Pircher
2009-01-12 5:12 ` Benjamin Herrenschmidt
2009-01-12 23:39 ` [PATCH 1/5] powerpc: Add platform support for AmigaOne Gerhard Pircher
2009-01-12 5:08 ` Benjamin Herrenschmidt
-- strict thread matches above, loose matches on Subject: below --
2009-01-12 23:39 [PATCH 2/5] powerpc: Generic device tree for all AmigaOne boards Gerhard Pircher
2009-01-13 5:01 ` Benjamin Herrenschmidt
2009-01-13 12:33 Gerhard Pircher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49652B79.5010502@freescale.com \
--to=scottwood@freescale.com \
--cc=grant.likely@secretlab.ca \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).