From: Julian Calaby <julian.calaby@gmail.com>
To: linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
Anatolij Gustschin <agust@denx.de>
Cc: Dmitry Baryshkov <dbaryshkov@gmail.com>,
Matteo Fortini <m.fortini@selcomgroup.com>,
Krzysztof Helt <krzysztof.h1@poczta.fm>
Subject: [PATCH] mb862xx: Restrict compliation of platform driver to PPC
Date: Mon, 12 Jan 2009 11:06:57 +1100 [thread overview]
Message-ID: <496A89A1.8050302@gmail.com> (raw)
mb862xx: Restrict compliation of platform driver to PPC
The OpenFirmware part of this driver is uncompilable on SPARC due to it's dependance on several PPC specific functions.
Restricting this to PPC to prevent these build errors.
This was found using randconfig builds.
Signed-off-by: Julian Calaby <julian.calaby@gmail.com>
---
A couple of notes:
1. After looking at the includes used by this driver, the OF part may not compile cleanly on PPC either as it doesn't appear to pull in the required headers for all the functions and constants it uses.
2. Also, this bug will *not* show up in allmodconfigs or allyesconfigs as the OF part of this driver is prevented from building when the PCI driver is built, and the PCI driver appears first.
3. This patch is over DaveM's sparc-2.6 git tree as of today.
4. I apologise for the massive cross-posting - I am not sure where exactly to send this patch.
5. Please note that I am not a member of any of these lists, so please keep me CC'd.
Thanks,
Julian Calaby
---
drivers/video/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index 6372f8b..8f18169 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
@@ -2111,6 +2111,7 @@ config FB_MB862XX_LIME
bool "Lime GDC"
depends on FB_MB862XX
depends on OF && !FB_MB862XX_PCI_GDC
+ depends on PPC
select FB_FOREIGN_ENDIAN
select FB_LITTLE_ENDIAN
---help---
next reply other threads:[~2009-01-12 0:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-12 0:06 Julian Calaby [this message]
2009-01-20 0:50 ` [PATCH] mb862xx: Restrict compliation of platform driver to PPC Julian Calaby
2009-01-20 1:19 ` Anton Vorontsov
2009-01-20 2:00 ` Julian Calaby
2009-01-23 10:31 ` Anatolij Gustschin
2009-01-20 13:57 ` Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=496A89A1.8050302@gmail.com \
--to=julian.calaby@gmail.com \
--cc=agust@denx.de \
--cc=dbaryshkov@gmail.com \
--cc=krzysztof.h1@poczta.fm \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=m.fortini@selcomgroup.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).