From: "Sachin P. Sant" <sachinp@in.ibm.com>
To: Willy Tarreau <w@1wt.eu>
Cc: Mel Gorman <mel@csn.ul.ie>, linuxppc-dev@ozlabs.org, greg@kroah.com
Subject: [Patch] fix lcd panel driver build failure
Date: Tue, 03 Feb 2009 21:10:58 +0530 [thread overview]
Message-ID: <4988658A.1060306@in.ibm.com> (raw)
In-Reply-To: <20090203152502.GC12398@1wt.eu>
[-- Attachment #1: Type: text/plain, Size: 96 bytes --]
* Fix build break for lcd panel driver.
Signed-off-by : Sachin Sant <sachinp@in.ibm.com>
---
[-- Attachment #2: staging-panel-build-break-fix.patch --]
[-- Type: text/x-patch, Size: 1215 bytes --]
* Fix build break for lcd panel driver.
Signed-off-by : Sachin Sant <sachinp@in.ibm.com>
---
diff -Naurp a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
--- a/drivers/staging/panel/panel.c 2009-02-03 23:34:18.000000000 +0530
+++ b/drivers/staging/panel/panel.c 2009-02-03 23:33:16.000000000 +0530
@@ -622,7 +622,7 @@ static int set_ctrl_bits(void)
}
/* sets ctrl & data port bits according to current signals values */
-static void set_bits(void)
+static void panel_set_bits(void)
{
set_data_bits();
set_ctrl_bits();
@@ -707,12 +707,12 @@ static void lcd_send_serial(int byte)
*/
for (bit = 0; bit < 8; bit++) {
bits.cl = BIT_CLR; /* CLK low */
- set_bits();
+ panel_set_bits();
bits.da = byte & 1;
- set_bits();
+ panel_set_bits();
udelay(2); /* maintain the data during 2 us before CLK up */
bits.cl = BIT_SET; /* CLK high */
- set_bits();
+ panel_set_bits();
udelay(1); /* maintain the strobe during 1 us */
byte >>= 1;
}
@@ -727,7 +727,7 @@ static void lcd_backlight(int on)
/* The backlight is activated by seting the AUTOFEED line to +5V */
spin_lock(&pprt_lock);
bits.bl = on;
- set_bits();
+ panel_set_bits();
spin_unlock(&pprt_lock);
}
next prev parent reply other threads:[~2009-02-03 15:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-03 15:15 2.6.29-rc3-git5 build failure : drivers/staging/panel Sachin P. Sant
2009-02-03 15:25 ` Willy Tarreau
2009-02-03 15:40 ` Sachin P. Sant [this message]
2009-02-03 15:47 ` [Patch] fix lcd panel driver build failure Willy Tarreau
2009-02-03 15:51 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4988658A.1060306@in.ibm.com \
--to=sachinp@in.ibm.com \
--cc=greg@kroah.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=mel@csn.ul.ie \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).