From: "Sachin P. Sant" <sachinp@in.ibm.com>
To: Geoff Levand <geoffrey.levand@am.sony.com>
Cc: Mel Gorman <mel@csn.ul.ie>,
Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>,
linuxppc-dev@ozlabs.org
Subject: Re: [patch] powerpc/ps3: Use hard coded values for LV1 device type
Date: Sat, 07 Feb 2009 23:11:28 +0530 [thread overview]
Message-ID: <498DC7C8.9090508@in.ibm.com> (raw)
In-Reply-To: <498CF52E.4040903@am.sony.com>
Geoff Levand wrote:
> Change the PS3 platform code to use hard coded numbers for its
> LV1 device types.
>
> The PS3 platform code was incorrectly using some scsi block
> constants for the device type returned from the LV1 hypervisor.
>
> Fixes build errors like these when CONFIG_BLOCK=n:
>
> In file included from include/scsi/scsi.h:12,
> from arch/powerpc/platforms/ps3/platform.h:25,
> from arch/powerpc/platforms/ps3/setup.c:36:
> include/scsi/scsi_cmnd.h:27:25: warning: "BLK_MAX_CDB" is not defined
> include/scsi/scsi_cmnd.h:28:3: error: #error MAX_COMMAND_SIZE can not be bigger than BLK_MAX_CDB
>
> Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
> ---
Thanks Geoff. This fixes the issue.
Tested-by : Sachin Sant <sachinp@in.ibm.com>
--
---------------------------------
Sachin Sant
IBM Linux Technology Center
India Systems and Technology Labs
Bangalore, India
---------------------------------
next prev parent reply other threads:[~2009-02-07 17:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-06 16:58 2.6.29-rc3-git9 build break : arch/powerpc/platforms/ps3/setup.o Sachin P. Sant
2009-02-07 2:42 ` [patch] powerpc/ps3: Use hard coded values for LV1 device type Geoff Levand
2009-02-07 17:41 ` Sachin P. Sant [this message]
2009-02-08 11:29 ` Michael Ellerman
2009-02-09 0:11 ` Benjamin Herrenschmidt
2009-02-09 3:59 ` James Bottomley
2009-02-10 22:46 ` Geoff Levand
2009-02-11 5:28 ` Sachin P. Sant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=498DC7C8.9090508@in.ibm.com \
--to=sachinp@in.ibm.com \
--cc=geoffrey.levand@am.sony.com \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).