From: Scott Wood <oss@buserror.net>
To: Laurentiu Tudor <laurentiu.tudor@nxp.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"mpe@ellerman.id.au" <mpe@ellerman.id.au>
Cc: Diana Madalina Craciun <diana.craciun@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] powerpc/fsl_booke: avoid creating duplicate tlb1 entry
Date: Sat, 29 Feb 2020 17:09:22 -0600 [thread overview]
Message-ID: <498ce16efb7784d95569d000bfab33ae25b823bd.camel@buserror.net> (raw)
In-Reply-To: <20200123111914.2565-1-laurentiu.tudor@nxp.com>
On Thu, 2020-01-23 at 11:19 +0000, Laurentiu Tudor wrote:
> In the current implementation, the call to loadcam_multi() is wrapped
> between switch_to_as1() and restore_to_as0() calls so, when it tries
> to create its own temporary AS=1 TLB1 entry, it ends up duplicating the
> existing one created by switch_to_as1(). Add a check to skip creating
> the temporary entry if already running in AS=1.
>
> Fixes: d9e1831a4202 ("powerpc/85xx: Load all early TLB entries at once")
> Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
> Cc: stable@vger.kernel.org
> ---
> arch/powerpc/mm/nohash/tlb_low.S | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
Assuming you've tested this on all combinations of 32/64 relocatable and not:
Acked-by: Scott Wood <oss@buserror.net>
-Scott
next prev parent reply other threads:[~2020-02-29 23:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-23 11:19 [PATCH] powerpc/fsl_booke: avoid creating duplicate tlb1 entry Laurentiu Tudor
2020-02-29 23:09 ` Scott Wood [this message]
2020-03-17 13:14 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=498ce16efb7784d95569d000bfab33ae25b823bd.camel@buserror.net \
--to=oss@buserror.net \
--cc=diana.craciun@nxp.com \
--cc=laurentiu.tudor@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).