From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>,
benh@kernel.crashing.org, christophe.leroy@c-s.fr,
tglx@linutronix.de, paulus@samba.org, cai@lca.pw,
oss@buserror.net
Cc: Chris Packham <chris.packham@alliedtelesis.co.nz>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] powerpc/setup_64: Set cache-line-size based on cache-block-size
Date: Sun, 26 Apr 2020 09:51:15 +1000 (AEST) [thread overview]
Message-ID: <498nql587Wz9sSJ@ozlabs.org> (raw)
In-Reply-To: <20200416221908.7886-1-chris.packham@alliedtelesis.co.nz>
On Thu, 2020-04-16 at 22:19:08 UTC, Chris Packham wrote:
> If {i,d}-cache-block-size is set and {i,d}-cache-line-size is not, use
> the block-size value for both. Per the devicetree spec cache-line-size
> is only needed if it differs from the block size.
>
> Originally the code would fallback from block size to line size. An
> error message was printed if both properties were missing.
>
> Later the code was refactored to use clearer names and logic but it
> inadvertently made line size a required property. This caused the
> default values to be used and in turn leads to Power9 systems using the
> wrong size.
>
> Fixes: bd067f83b084 ("powerpc/64: Fix naming of cache block vs. cache lin=
> e")
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/94c0b013c98583614e1ad911e8795ca36da34a85
cheers
prev parent reply other threads:[~2020-04-25 23:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 22:19 [PATCH v3] powerpc/setup_64: Set cache-line-size based on cache-block-size Chris Packham
2020-04-25 23:51 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=498nql587Wz9sSJ@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=benh@kernel.crashing.org \
--cc=cai@lca.pw \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=christophe.leroy@c-s.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=oss@buserror.net \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).