From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from WA4EHSOBE005.bigfish.com (outbound-wa4.frontbridge.com [216.32.181.16]) by ozlabs.org (Postfix) with ESMTP id 58F5EDDDA0 for ; Tue, 10 Feb 2009 07:16:31 +1100 (EST) Message-ID: <49908F14.50703@am.sony.com> Date: Mon, 9 Feb 2009 12:16:20 -0800 From: Geoff Levand MIME-Version: 1.0 To: Steven Rostedt Subject: Re: [PATCH] ftrace, powerpc64: fix math to calculate offset in TOC References: In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1" Cc: Arnd Bergmann , LKML , linuxppc-dev@ozlabs.org, Paul Mackerras , Remis Lima Baima , Ingo Molnar List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Steven Rostedt wrote: > I found the bug that was causing large modules to fail in setting > up dynamic ftrace. It wound up being a simple math error. To calculate > the offset in the TOC, I had used an OR, but the bottom half was > a signed extended short, and it should have been an addition. > The fix is in my tree below, as well as posted here. > ---- > arch/powerpc/kernel/ftrace.c | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) I tested this on PS3 with CONFIG_FTRACE_SELFTEST=y and CONFIG_FTRACE_SELFTEST=y, and all modules now load and the system seems to work properly. I did not run any tracer specific tests though. Acked-by: Geoff Levand