[PATCH] powerpc: Remove extra semicolon in fsl_soc.c (2nd try)

[PATCH] powerpc: Remove extra semicolon in fsl_soc.c (2nd try)

[Johns Daniel]

TSEC/MDIO will not work with older device trees because of a semicolon 
at the end of a macro resulting in an empty for loop body.

This fix only applies to 2.6.28; this code is gone in 2.6.29, according 
to Grant Likely!

Signed-off-by: Johns Daniel <johns.daniel@gmail.com 
<mailto:johns.daniel@gmail.com>>
======================================

--- linux-2.6.28.7/arch/powerpc/sysdev/fsl_soc.c.orig	2009-02-20 16:41:27.000000000 -0600
+++ linux-2.6.28.7/arch/powerpc/sysdev/fsl_soc.c	2009-03-14 09:01:38.994630400 -0500
@@ -257,7 +257,7 @@ static int __init gfar_mdio_of_init(void
		gfar_mdio_of_init_one(np);

	/* try the deprecated version */
-	for_each_compatible_node(np, "mdio", "gianfar");
+	for_each_compatible_node(np, "mdio", "gianfar")
		gfar_mdio_of_init_one(np);

	return 0;

Re: [PATCH] powerpc: Remove extra semicolon in fsl_soc.c (2nd try)

[Grant Likely]

On Sat, Mar 14, 2009 at 9:03 AM, Johns Daniel <jdaniel@computer.org> wrote:
> TSEC/MDIO will not work with older device trees because of a semicolon at
> the end of a macro resulting in an empty for loop body.
>
> This fix only applies to 2.6.28; this code is gone in 2.6.29, according t=
o
> Grant Likely!
>
> Signed-off-by: Johns Daniel <johns.daniel@gmail.com
> <mailto:johns.daniel@gmail.com>>

Your signed-off-by line is odd.  I assume your mailer did this to you.
 But in case Greg picks it up anyway:

Acked-by: Grant Likely <grant.likely@secretlab.ca>

> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>
> --- linux-2.6.28.7/arch/powerpc/sysdev/fsl_soc.c.orig =A0 2009-02-20
> 16:41:27.000000000 -0600
> +++ linux-2.6.28.7/arch/powerpc/sysdev/fsl_soc.c =A0 =A0 =A0 =A02009-03-1=
4
> 09:01:38.994630400 -0500
> @@ -257,7 +257,7 @@ static int __init gfar_mdio_of_init(void
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0gfar_mdio_of_init_one(np);
>
> =A0 =A0 =A0 =A0/* try the deprecated version */
> - =A0 =A0 =A0 for_each_compatible_node(np, "mdio", "gianfar");
> + =A0 =A0 =A0 for_each_compatible_node(np, "mdio", "gianfar")
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0gfar_mdio_of_init_one(np);
>
> =A0 =A0 =A0 =A0return 0;
>
>
>



--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.