From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from az33egw02.freescale.net (az33egw02.freescale.net [192.88.158.103]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "az33egw02.freescale.net", Issuer "Thawte Premium Server CA" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id 646E2DDDF3 for ; Thu, 19 Mar 2009 07:35:17 +1100 (EST) Message-ID: <49C15AFF.3050708@freescale.com> Date: Wed, 18 Mar 2009 15:35:11 -0500 From: Scott Wood MIME-Version: 1.0 To: avorontsov@ru.mvista.com Subject: Re: [PATCH v3 3/4] powerpc/85xx: Move gianfar mdio nodes under the ethernet nodes References: <20090318195911.GA31525@oksana.dev.rtsoft.ru> <20090318200039.GC8182@oksana.dev.rtsoft.ru> <49C1541F.8040803@freescale.com> <20090318202344.GA9708@oksana.dev.rtsoft.ru> <20090318202947.GA14504@oksana.dev.rtsoft.ru> <49C15A21.3050002@freescale.com> <20090318203327.GA15378@oksana.dev.rtsoft.ru> In-Reply-To: <20090318203327.GA15378@oksana.dev.rtsoft.ru> Content-Type: text/plain; charset=UTF-8; format=flowed Cc: linuxppc-dev@ozlabs.org, Li Yang List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Anton Vorontsov wrote: > On Wed, Mar 18, 2009 at 03:31:29PM -0500, Scott Wood wrote: >> Anton Vorontsov wrote: >>> On Wed, Mar 18, 2009 at 11:23:44PM +0300, Anton Vorontsov wrote: >>>> I don't see any better solution, should I just leave the core1's >>>> mdio node intact? >>> Ah. We also could change compatible entry to "fsl,gianfar-slave". >>> This will prevent gianfar MAC driver to probe on core1. >> ...and also prevent it from probing the children, unless simple-bus is >> specified, or Linux is given special knowledge of the >> "fsl,gianfar-slave" name. > > Yup. Do you see any problem with this? Yes, the mdio node would not get probed. Why put it in the device tree at all then? -Scott