linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: Li Yang-R58472 <LeoLi@freescale.com>
Cc: linuxppc-dev@ozlabs.org, Soohyung Cho <celius202@gmail.com>
Subject: Re: suspend-to-mem on the mpc8349e-mitx-gp?
Date: Fri, 20 Mar 2009 09:41:57 -0500	[thread overview]
Message-ID: <49C3AB35.4080700@freescale.com> (raw)
In-Reply-To: <3A45394FD742FA419B760BB8D398F9ED29EB95@zch01exm26.fsl.freescale.net>

Li Yang-R58472 wrote:
>> However, the code should treat "mem" as "standby" on chips 
>> that don't support deep sleep.  What does the device tree 
> 
> Well, shouldn't the valid() callback reject unsupported states instead
> of covering up?

I don't think so, in this case.  The user is not asking for "sleep" or 
deep sleep"; they are asking for a power state that meets the definition 
of "standby" (which sleep does) or which meets the definition of "mem" 
(which both sleep and deep sleep do).  When the user asks for "mem", we 
provide the lowest power mode that qualifies.

I'm willing to change it if there's substantial existing practice to the 
contrary, though.

-Scott

  reply	other threads:[~2009-03-20 14:42 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-19  5:46 suspend-to-mem on the mpc8349e-mitx-gp? Soohyung Cho
2009-03-19  7:24 ` Li Yang-R58472
2009-03-19 16:11   ` Scott Wood
2009-03-20  3:43     ` Li Yang-R58472
2009-03-20 14:41       ` Scott Wood [this message]
2009-03-23  5:45         ` Li Yang-R58472
2009-03-23  6:16           ` MJ embd
2009-03-23  6:17           ` Soohyung Cho
2009-03-23 16:54           ` Scott Wood
2009-03-25 10:42             ` Li Yang
2009-03-25 11:11               ` Pavel Machek
2009-03-25 16:31                 ` Scott Wood
2009-03-25 18:23                   ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49C3AB35.4080700@freescale.com \
    --to=scottwood@freescale.com \
    --cc=LeoLi@freescale.com \
    --cc=celius202@gmail.com \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).