linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
Cc: linuxppc-dev@ozlabs.org, Li Yang <leoli@freescale.com>,
	pku.leo@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] ucc_geth: Rework the TX logic.
Date: Fri, 27 Mar 2009 08:26:00 -0500	[thread overview]
Message-ID: <49CCD3E8.9040007@freescale.com> (raw)
In-Reply-To: <OFDCE90357.0EDC5DC1-ONC1257586.003759A3-C1257586.00390AD3@transmode.se>

Joakim Tjernlund wrote:
> This is a bit better than the current type casts. Moving over to qe_bd
> accesses is a bigger cleanup that will have to be a seperate patch.
> I am not sure it is an all win as you probably loose the ability
> to read both status and len in one access.

Not if you define the struct to have one status_len field (or a union of 
that with separate fields), as gianfar does.

-Scott

  parent reply	other threads:[~2009-03-27 13:26 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-26 17:44 [PATCH] ucc_geth: Rework the TX logic Joakim Tjernlund
2009-03-26 18:03 ` Anton Vorontsov
2009-03-26 18:26   ` Joakim Tjernlund
2009-03-27  9:45 ` Li Yang
2009-03-27 10:23   ` Joakim Tjernlund
2009-03-27 10:39     ` Li Yang
2009-03-27 11:39       ` Joakim Tjernlund
2009-03-27 13:26     ` Scott Wood [this message]
2009-03-30 16:38       ` Joakim Tjernlund
2009-03-30 17:22         ` Scott Wood
2009-03-30 17:34           ` Joakim Tjernlund
2009-03-30 17:45             ` Scott Wood
2009-03-30 18:42               ` Joakim Tjernlund
2009-03-30 19:32                 ` Scott Wood
2009-03-31  9:07                   ` Joakim Tjernlund
2009-03-31 10:58                     ` Li Yang
2009-03-31 14:37                     ` Scott Wood
2009-03-31  8:16           ` Li Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49CCD3E8.9040007@freescale.com \
    --to=scottwood@freescale.com \
    --cc=Joakim.Tjernlund@transmode.se \
    --cc=leoli@freescale.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=netdev@vger.kernel.org \
    --cc=pku.leo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).