linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Sachin Sant <sachinp@in.ibm.com>
To: linuxppc-dev@ozlabs.org
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, jk@ozlabs.org
Subject: [Patch next] powerpc: pseries/dtl.c should include asm/firmware.h
Date: Wed, 01 Apr 2009 15:57:42 +0530	[thread overview]
Message-ID: <49D3419E.7000005@in.ibm.com> (raw)
In-Reply-To: <20090401164450.f8192631.sfr@canb.auug.org.au>

[-- Attachment #1: Type: text/plain, Size: 558 bytes --]

randconfig build on powerpc failed with :


arch/powerpc/platforms/pseries/dtl.c: In function ‘dtl_init’:
arch/powerpc/platforms/pseries/dtl.c:238: error: implicit declaration of function ‘firmware_has_feature’
arch/powerpc/platforms/pseries/dtl.c:238: error: ‘FW_FEATURE_SPLPAR’ undeclared (first use in this function)
arch/powerpc/platforms/pseries/dtl.c:238: error: (Each undeclared identifier is reported only once
arch/powerpc/platforms/pseries/dtl.c:238: error: for each function it appears in.)

Signed-off-by : Sachin Sant <sachinp@in.ibm.com>
---



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: fix-dtl-build-break.patch --]
[-- Type: text/x-patch; name="fix-dtl-build-break.patch", Size: 1005 bytes --]

* Fixes the following build error
*
* arch/powerpc/platforms/pseries/dtl.c: In function ‘dtl_init’:
* arch/powerpc/platforms/pseries/dtl.c:238:
*       error: implicit declaration of function ‘firmware_has_feature’
* arch/powerpc/platforms/pseries/dtl.c:238:
*       error: ‘FW_FEATURE_SPLPAR’ undeclared (first use in this function)
* arch/powerpc/platforms/pseries/dtl.c:238:
*        error: (Each undeclared identifier is reported only once
* arch/powerpc/platforms/pseries/dtl.c:238: 
*        error: for each function it appears in.)

Signed-off-by : Sachin Sant <sachinp@in.ibm.com>
---

diff -Naurp a/arch/powerpc/platforms/pseries/dtl.c b/arch/powerpc/platforms/pseries/dtl.c
--- a/arch/powerpc/platforms/pseries/dtl.c	2009-04-01 15:46:59.000000000 +0530
+++ b/arch/powerpc/platforms/pseries/dtl.c	2009-04-01 15:47:58.000000000 +0530
@@ -25,6 +25,7 @@
 #include <asm/smp.h>
 #include <asm/system.h>
 #include <asm/uaccess.h>
+#include <asm/firmware.h>
 
 #include "plpar_wrappers.h"
 

       reply	other threads:[~2009-04-01 10:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20090401164450.f8192631.sfr@canb.auug.org.au>
2009-04-01 10:27 ` Sachin Sant [this message]
2009-04-02  0:34   ` [Patch next] powerpc: pseries/dtl.c should include asm/firmware.h Michael Neuling
2009-04-02  5:31     ` Sachin Sant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49D3419E.7000005@in.ibm.com \
    --to=sachinp@in.ibm.com \
    --cc=jk@ozlabs.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).