[Patch next] powerpc: pseries/dtl.c should include asm/firmware.h

[Patch next] powerpc: pseries/dtl.c should include asm/firmware.h

[Sachin Sant]

[-- Attachment #1: Type: text/plain, Size: 558 bytes --]

randconfig build on powerpc failed with :


arch/powerpc/platforms/pseries/dtl.c: In function ‘dtl_init’:
arch/powerpc/platforms/pseries/dtl.c:238: error: implicit declaration of function ‘firmware_has_feature’
arch/powerpc/platforms/pseries/dtl.c:238: error: ‘FW_FEATURE_SPLPAR’ undeclared (first use in this function)
arch/powerpc/platforms/pseries/dtl.c:238: error: (Each undeclared identifier is reported only once
arch/powerpc/platforms/pseries/dtl.c:238: error: for each function it appears in.)

Signed-off-by : Sachin Sant <sachinp@in.ibm.com>
---



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: fix-dtl-build-break.patch --]
[-- Type: text/x-patch; name="fix-dtl-build-break.patch", Size: 1005 bytes --]

* Fixes the following build error
*
* arch/powerpc/platforms/pseries/dtl.c: In function ‘dtl_init’:
* arch/powerpc/platforms/pseries/dtl.c:238:
*       error: implicit declaration of function ‘firmware_has_feature’
* arch/powerpc/platforms/pseries/dtl.c:238:
*       error: ‘FW_FEATURE_SPLPAR’ undeclared (first use in this function)
* arch/powerpc/platforms/pseries/dtl.c:238:
*        error: (Each undeclared identifier is reported only once
* arch/powerpc/platforms/pseries/dtl.c:238: 
*        error: for each function it appears in.)

Signed-off-by : Sachin Sant <sachinp@in.ibm.com>
---

diff -Naurp a/arch/powerpc/platforms/pseries/dtl.c b/arch/powerpc/platforms/pseries/dtl.c
--- a/arch/powerpc/platforms/pseries/dtl.c	2009-04-01 15:46:59.000000000 +0530
+++ b/arch/powerpc/platforms/pseries/dtl.c	2009-04-01 15:47:58.000000000 +0530
@@ -25,6 +25,7 @@
 #include <asm/smp.h>
 #include <asm/system.h>
 #include <asm/uaccess.h>
+#include <asm/firmware.h>
 
 #include "plpar_wrappers.h"
 

Re: [Patch next] powerpc: pseries/dtl.c should include asm/firmware.h

[Michael Neuling]

> randconfig build on powerpc failed with :
>=20
>=20
> arch/powerpc/platforms/pseries/dtl.c: In function =C2=91dtl_init=C2=92:
> arch/powerpc/platforms/pseries/dtl.c:238: error: implicit declaration of =
func
tion =C2=91firmware_has_feature=C2=92
> arch/powerpc/platforms/pseries/dtl.c:238: error: =C2=91FW_FEATURE_SPLPAR=
=C2=92 undeclared
 (first use in this function)
> arch/powerpc/platforms/pseries/dtl.c:238: error: (Each undeclared identif=
ier=20
is reported only once
> arch/powerpc/platforms/pseries/dtl.c:238: error: for each function it app=
ears
 in.)
>=20
> Signed-off-by : Sachin Sant <sachinp@in.ibm.com>
> ---

It's great that you're sending patches to fix these issues but it's not
quite formatted as the maintainers like.

The patch needs to be included inline in the message, rather than as an
attachment.  You can see it as an attachment here:
  http://ozlabs.org/pipermail/linuxppc-dev/2009-April/070122.html
.. as opposed to the required inline format like this patch:
  http://ozlabs.org/pipermail/linuxppc-dev/2009-April/070120.html

Adding a diffstat would also be nice.

Mikey

>=20
>=20
>=20
> --------------050404090408000502010008
> Content-Type: text/x-patch;
>  name=3D"fix-dtl-build-break.patch"
> Content-Transfer-Encoding: 8bit
> Content-Disposition: inline;
>  filename=3D"fix-dtl-build-break.patch"
>=20
> * Fixes the following build error
> *
> * arch/powerpc/platforms/pseries/dtl.c: In function =E2=80=98dtl_init=E2=
=80=99:
> * arch/powerpc/platforms/pseries/dtl.c:238:
> *       error: implicit declaration of function =E2=80=98firmware_has_fea=
ture=E2=80=99
> * arch/powerpc/platforms/pseries/dtl.c:238:
> *       error: =E2=80=98FW_FEATURE_SPLPAR=E2=80=99 undeclared (first use =
in this function)
> * arch/powerpc/platforms/pseries/dtl.c:238:
> *        error: (Each undeclared identifier is reported only once
> * arch/powerpc/platforms/pseries/dtl.c:238:=20
> *        error: for each function it appears in.)
>=20
> Signed-off-by : Sachin Sant <sachinp@in.ibm.com>
> ---
>=20
> diff -Naurp a/arch/powerpc/platforms/pseries/dtl.c b/arch/powerpc/platfor=
ms/p
series/dtl.c
> --- a/arch/powerpc/platforms/pseries/dtl.c	2009-04-01 15:46:59.000000000 +
0530
> +++ b/arch/powerpc/platforms/pseries/dtl.c	2009-04-01 15:47:58.000000000 +
0530
> @@ -25,6 +25,7 @@
>  #include <asm/smp.h>
>  #include <asm/system.h>
>  #include <asm/uaccess.h>
> +#include <asm/firmware.h>
>=20=20
>  #include "plpar_wrappers.h"
>=20=20
>=20
> --------------050404090408000502010008
> Content-Type: text/plain; charset=3D"us-ascii"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Content-Disposition: inline
>=20
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
> --------------050404090408000502010008--
>=20

Re: [Patch next] powerpc: pseries/dtl.c should include asm/firmware.h

[Sachin Sant]

Michael Neuling wrote:
> It's great that you're sending patches to fix these issues but it's not
> quite formatted as the maintainers like.
>
> The patch needs to be included inline in the message, rather than as an
> attachment.  You can see it as an attachment here:
>   http://ozlabs.org/pipermail/linuxppc-dev/2009-April/070122.html
> .. as opposed to the required inline format like this patch:
>   http://ozlabs.org/pipermail/linuxppc-dev/2009-April/070120.html
>   
Yeah .. just being lazy. Moving from thunderbird to mutt have been
on my TODO list for a long time. I will use this as a trigger to
move to a different mail client. Thanks Mikey.

Regards
-Sachin


-- 

---------------------------------
Sachin Sant
IBM Linux Technology Center
India Systems and Technology Labs
Bangalore, India
---------------------------------