* Re: [PATCH 3/3] powerpc: allow 256kB pages with SHMEM
2009-04-06 21:01 ` [PATCH 3/3] powerpc: allow 256kB pages with SHMEM Hugh Dickins
@ 2009-04-07 3:28 ` Paul Mackerras
2009-04-07 6:10 ` Hugh Dickins
2009-04-09 23:34 ` Andrew Morton
2009-04-16 16:50 ` Ilya Yanok
2 siblings, 1 reply; 6+ messages in thread
From: Paul Mackerras @ 2009-04-07 3:28 UTC (permalink / raw)
To: Hugh Dickins; +Cc: linuxppc-dev, Andrew Morton, prodyuth, linux-kernel, yanok
Hugh Dickins writes:
> Now that shmem's divisions by zero and SHMEM_MAX_BYTES are fixed,
> let powerpc 256kB pages coexist with CONFIG_SHMEM again.
>
> Signed-off-by: Hugh Dickins <hugh@veritas.com>
> ---
> Added linuxppc-dev and some other Cc's for this 3/3: sorry
> if you didn't see 1/3 and 2/3, they were just in mm/shmem.c.
Looks OK - what path are you using to get the series upstream?
(I.e. should I be putting 3/3 in the powerpc tree or are you going to
push it along with the others?)
Paul.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/3] powerpc: allow 256kB pages with SHMEM
2009-04-07 3:28 ` Paul Mackerras
@ 2009-04-07 6:10 ` Hugh Dickins
0 siblings, 0 replies; 6+ messages in thread
From: Hugh Dickins @ 2009-04-07 6:10 UTC (permalink / raw)
To: Paul Mackerras; +Cc: yanok, linux-kernel, linuxppc-dev, Andrew Morton, prodyuth
On Tue, 7 Apr 2009, Paul Mackerras wrote:
> Hugh Dickins writes:
>
> > Now that shmem's divisions by zero and SHMEM_MAX_BYTES are fixed,
> > let powerpc 256kB pages coexist with CONFIG_SHMEM again.
> >
> > Signed-off-by: Hugh Dickins <hugh@veritas.com>
> > ---
> > Added linuxppc-dev and some other Cc's for this 3/3: sorry
> > if you didn't see 1/3 and 2/3, they were just in mm/shmem.c.
>
> Looks OK - what path are you using to get the series upstream?
> (I.e. should I be putting 3/3 in the powerpc tree or are you going to
> push it along with the others?)
If it's OK with you (and you're saying it is), I think the best
would be for it to sit alongside 1/3 and 2/3 in Andrew's tree,
hopefully get an Ack from Yuri (I don't have any powerpc 256kB
pages myself to test it fully), and then go on into 2.6.30.
Hugh
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/3] powerpc: allow 256kB pages with SHMEM
2009-04-06 21:01 ` [PATCH 3/3] powerpc: allow 256kB pages with SHMEM Hugh Dickins
2009-04-07 3:28 ` Paul Mackerras
@ 2009-04-09 23:34 ` Andrew Morton
2009-04-10 8:58 ` Hugh Dickins
2009-04-16 16:50 ` Ilya Yanok
2 siblings, 1 reply; 6+ messages in thread
From: Andrew Morton @ 2009-04-09 23:34 UTC (permalink / raw)
To: Hugh Dickins; +Cc: yanok, linux-kernel, linuxppc-dev, prodyuth
On Mon, 6 Apr 2009 22:01:15 +0100 (BST)
Hugh Dickins <hugh@veritas.com> wrote:
> Now that shmem's divisions by zero and SHMEM_MAX_BYTES are fixed,
> let powerpc 256kB pages coexist with CONFIG_SHMEM again.
>
> Signed-off-by: Hugh Dickins <hugh@veritas.com>
> ---
> Added linuxppc-dev and some other Cc's for this 3/3: sorry
> if you didn't see 1/3 and 2/3, they were just in mm/shmem.c.
Do we think these patches should be in 2.6.30?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/3] powerpc: allow 256kB pages with SHMEM
2009-04-09 23:34 ` Andrew Morton
@ 2009-04-10 8:58 ` Hugh Dickins
0 siblings, 0 replies; 6+ messages in thread
From: Hugh Dickins @ 2009-04-10 8:58 UTC (permalink / raw)
To: Andrew Morton; +Cc: yanok, linux-kernel, linuxppc-dev, Paul Mackerras, prodyuth
On Thu, 9 Apr 2009, Andrew Morton wrote:
> On Mon, 6 Apr 2009 22:01:15 +0100 (BST)
> Hugh Dickins <hugh@veritas.com> wrote:
>
> > Now that shmem's divisions by zero and SHMEM_MAX_BYTES are fixed,
> > let powerpc 256kB pages coexist with CONFIG_SHMEM again.
> >
> > Signed-off-by: Hugh Dickins <hugh@veritas.com>
> > ---
> > Added linuxppc-dev and some other Cc's for this 3/3: sorry
> > if you didn't see 1/3 and 2/3, they were just in mm/shmem.c.
>
> Do we think these patches should be in 2.6.30?
I think so - 2.6.30 will have the rest of Yuri's 256kB page support.
But it would be nice to have an Ack from Yuri before sending these
on through. 2/3 is a bugfix justified even without 256kB pages -
I should have inverted the ordering.
Hugh
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/3] powerpc: allow 256kB pages with SHMEM
2009-04-06 21:01 ` [PATCH 3/3] powerpc: allow 256kB pages with SHMEM Hugh Dickins
2009-04-07 3:28 ` Paul Mackerras
2009-04-09 23:34 ` Andrew Morton
@ 2009-04-16 16:50 ` Ilya Yanok
2 siblings, 0 replies; 6+ messages in thread
From: Ilya Yanok @ 2009-04-16 16:50 UTC (permalink / raw)
To: Hugh Dickins; +Cc: linux-kernel, linuxppc-dev, Andrew Morton, prodyuth
Hi Hugh,
Hugh Dickins wrote:
> Now that shmem's divisions by zero and SHMEM_MAX_BYTES are fixed,
> let powerpc 256kB pages coexist with CONFIG_SHMEM again.
>
> Signed-off-by: Hugh Dickins <hugh@veritas.com>
>
Acked-by: Ilya Yanok <yanok@emcraft.com>
> ---
> Added linuxppc-dev and some other Cc's for this 3/3: sorry
> if you didn't see 1/3 and 2/3, they were just in mm/shmem.c.
>
> arch/powerpc/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- 2.6.29-git13/arch/powerpc/Kconfig 2009-04-06 11:47:57.000000000 +0100
> +++ linux/arch/powerpc/Kconfig 2009-04-06 18:18:47.000000000 +0100
> @@ -462,7 +462,7 @@ config PPC_64K_PAGES
>
> config PPC_256K_PAGES
> bool "256k page size" if 44x
> - depends on !STDBINUTILS && (!SHMEM || BROKEN)
> + depends on !STDBINUTILS
> help
> Make the page size 256k.
>
>
Regards, Ilya.
^ permalink raw reply [flat|nested] 6+ messages in thread