From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e35.co.us.ibm.com (e35.co.us.ibm.com [32.97.110.153]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "e35.co.us.ibm.com", Issuer "Equifax" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id BAFBBDE03F for ; Wed, 22 Apr 2009 04:55:57 +1000 (EST) Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e35.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id n3LIoRZ9014581 for ; Tue, 21 Apr 2009 12:50:27 -0600 Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n3LItpLX077592 for ; Tue, 21 Apr 2009 12:55:51 -0600 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n3LItonh013546 for ; Tue, 21 Apr 2009 12:55:51 -0600 Message-ID: <49EE16B4.4000504@us.ibm.com> Date: Tue, 21 Apr 2009 11:55:48 -0700 From: Mike Mason MIME-Version: 1.0 To: Paul Mackerras Subject: Re: [PATCH] Set error_state to pci_channel_io_normal in eeh_report_reset() References: <49DF967F.4000205@us.ibm.com> <18917.31205.828267.202889@drongo.ozlabs.ibm.com> In-Reply-To: <18917.31205.828267.202889@drongo.ozlabs.ibm.com> Content-Type: text/html; charset=ISO-8859-1 Cc: linuxppc-dev@ozlabs.org, linasvepstas@gmail.com, Richard Lary List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Paul Mackerras wrote: 
Mike Mason writes:

  
diff --git a/arch/powerpc/platforms/pseries/eeh_driver.c 
b/arch/powerpc/platforms/pseries/eeh_driver.c
index 380420f..9a2a6e3 100644
--- a/arch/powerpc/platforms/pseries/eeh_driver.c
+++ b/arch/powerpc/platforms/pseries/eeh_driver.c
@@ -182,6 +182,8 @@ static void eeh_report_reset(struct pci_dev *dev, 
void *userdata)
if (!driver)
return;

+ dev->error_state = pci_channel_io_normal;
+
eeh_enable_irq(dev);

if (!driver->err_handler ||
    

Your mail client totally mangled the whitespace.  I fixed it up and
applied it, since the patch was small, but in future please fix your
mail client so it doesn't do that.
Sorry about that.
It sounds like this patch needs to be applied to earlier kernel
versions -- do you agree?
Maybe.  The only drivers that care at this point are the emulex and qlogic drivers with native eeh support.  How far back would you typically apply a patch like this?  I'm submitting it for inclusion in SLES 10 & 11 and RHEL 5.

Mike
Paul.