From: Scott Wood <scottwood@freescale.com>
To: Benjamin Krill <ben@codiert.org>
Cc: Ricardo Ribalda Delgado <ricardo.ribalda@uam.es>,
linuxppc-dev@ozlabs.org, David.Woodhouse@intel.com
Subject: Re: ofpart: Partitions at same address cannot have the same name
Date: Wed, 22 Apr 2009 12:27:45 -0500 [thread overview]
Message-ID: <49EF5391.9050404@freescale.com> (raw)
In-Reply-To: <20090422171030.GH14906@codiert.org>
Benjamin Krill wrote:
>> --- a/drivers/mtd/ofpart.c
>> +++ b/drivers/mtd/ofpart.c
>> @@ -48,7 +48,7 @@ int __devinit of_mtd_parse_partitions(struct device *dev,
>>
>> /* check if this is a partition node */
>> partname = of_get_property(pp, "name", &len);
>> - if (strcmp(partname, "partition") != 0) {
>> + if (strncmp(partname, "partition", strlen("partition") != 0) {
Perhaps "compatible" should be used instead?
> Hi Recardo,
>
> I would suggest to do:
>
> if (strcmp(partname, "partition") <= 0) {
Check whether it sorts alphabetically before "partition"? Why?
-Scott
next prev parent reply other threads:[~2009-04-22 17:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-22 8:05 [MTD] ofpart: Partitions at same address cannot have the same name Ricardo Ribalda Delgado
2009-04-22 9:24 ` Peter Korsgaard
2009-04-22 15:34 ` Ricardo Ribalda Delgado
2009-04-22 15:52 ` Ricardo Ribalda Delgado
2009-04-22 17:10 ` Benjamin Krill
2009-04-22 17:27 ` Scott Wood [this message]
2009-04-22 17:56 ` Ricardo Ribalda Delgado
2009-04-22 18:11 ` Scott Wood
2009-04-22 18:58 ` Ricardo Ribalda Delgado
2009-04-22 17:59 ` Ricardo Ribalda Delgado
2009-04-22 18:33 ` Benjamin Krill
2009-04-30 3:19 ` [MTD] " Benjamin Herrenschmidt
2009-04-30 5:32 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49EF5391.9050404@freescale.com \
--to=scottwood@freescale.com \
--cc=David.Woodhouse@intel.com \
--cc=ben@codiert.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=ricardo.ribalda@uam.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).