linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: David Hawkins <dwh@ovro.caltech.edu>
To: Timur Tabi <timur@freescale.com>
Cc: linuxppc-dev@ozlabs.org, Dan Williams <dan.j.williams@intel.com>,
	Liu Dave-R63238 <DaveLiu@freescale.com>,
	linux-kernel@vger.kernel.org, Ira Snyder <iws@ovro.caltech.edu>
Subject: Re: [PATCH] fsldma: use PCI Read Multiple command
Date: Mon, 27 Apr 2009 13:22:46 -0700	[thread overview]
Message-ID: <49F61416.8040501@ovro.caltech.edu> (raw)
In-Reply-To: <49F60A3A.4060402@freescale.com>

Hi Timur,

>> Would you like some sort of summary of this info for a commit
>> message?
> 
> That's probably overkill.  I just want a sentence or two that tells
> someone looking at the code casually that the behavior of reading PCI
> memory might be different than what they expect.

Could you help us with the wording you'd like to see in the code.
Did you want to see something in the header comments, or something
near the register settings?

How about something like this in place of the existing PCI_RM
comment:

PRC_RM - PCI read multiple
   The default PCI read command used by the DMA controller is
   PCI Read (PCI command 6h). When the burst length is 32-bytes
   or longer, PCI Read Line (PCI command Eh) is used (undocumented
   feature of the controller). Using PCI read multiple
   (PCI command Ch) results in high-performance across PCI
   bridges. DMA transfers to non-prefetchable PCI registers
   should not result in prefetched reads, even when using
   the PCI read multiple command.


Cheers,
Dave

  parent reply	other threads:[~2009-04-27 20:22 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-24 18:35 [PATCH] fsldma: use PCI Read Multiple command Ira Snyder
2009-04-27  7:48 ` Li Yang
2009-04-27  9:09 ` Liu Dave-R63238
2009-04-27 10:16   ` Li Yang
2009-04-27 14:31   ` Timur Tabi
2009-04-27 19:34     ` David Hawkins
2009-04-27 19:40       ` Timur Tabi
2009-04-27 19:48         ` David Hawkins
2009-04-27 19:54           ` Kumar Gala
2009-04-27 20:00             ` David Hawkins
2009-04-27 20:01               ` David Hawkins
2009-04-28  2:06                 ` Liu Dave-R63238
2009-04-27 20:02               ` Kumar Gala
2009-04-27 20:12                 ` David Hawkins
2009-04-27 20:04           ` Timur Tabi
2009-04-27 20:47             ` Scott Wood
2009-04-27 20:49               ` Timur Tabi
2009-04-27 20:22         ` David Hawkins [this message]
2009-04-27 20:26           ` Timur Tabi
2009-04-27 20:41             ` David Hawkins
2009-04-27 20:42               ` Timur Tabi
2009-04-27 20:44                 ` David Hawkins
2009-04-27 20:42             ` Ira Snyder
2009-04-27 20:47               ` Timur Tabi
2009-04-27 20:49                 ` Dan Williams
2009-06-11  2:45                   ` Kumar Gala
2009-06-11 15:17                     ` Ira Snyder
2009-06-12  9:23                       ` Li Yang
2009-06-12 15:03                         ` Kumar Gala
2009-06-12 17:38                           ` Dan Williams
2009-06-12 18:01                             ` Kumar Gala
2009-04-28  1:48       ` Liu Dave-R63238
2009-04-28  2:08         ` David Hawkins
2009-04-27 21:59     ` Liu Dave-R63238
2009-04-28  1:31     ` Liu Dave-R63238
2009-04-28  1:36       ` David Hawkins
2009-04-28 13:43         ` Timur Tabi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49F61416.8040501@ovro.caltech.edu \
    --to=dwh@ovro.caltech.edu \
    --cc=DaveLiu@freescale.com \
    --cc=dan.j.williams@intel.com \
    --cc=iws@ovro.caltech.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=timur@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).