From: "H. Peter Anvin" <hpa@zytor.com>
To: Tim Abbott <tabbott@MIT.EDU>
Cc: linux-mips@linux-mips.org, linux-m68k@vger.kernel.org,
linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org,
Denys Vlasenko <vda.linux@googlemail.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>,
Greg Ungerer <gerg@uclinux.org>,
sparclinux@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-s390@vger.kernel.org,
Jesper Nilsson <jesper.nilsson@axis.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Helge Deller <deller@gmx.de>, Ingo Molnar <mingo@redhat.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Russell King <rmk+kernel@arm.linux.org.uk>,
user-mode-linux-devel@lists.sourceforge.net,
microblaze-uclinux@itee.uq.edu.au, Jeff Dike <jdike@addtoit.com>,
Jeff Arnold <jbarnold@MIT.EDU>,
dev-etrax@axis.com, Mikael Starvik <starvik@axis.com>,
Cyrill Gorcunov <gorcunov@openvz.org>,
Michal Simek <monstr@monstr.eu>, Waseem Daher <wdaher@MIT.EDU>,
Richard Henderson <rth@twiddle.net>,
Chris Zankel <chris@zankel.net>, Bryan Wu <cooloney@kernel.org>,
Tony Luck <tony.luck@intel.com>,
linux-parisc@vger.kernel.org,
Haavard Skinnemoen <hskinnemoen@atmel.com>,
Hirokazu Takata <takata@linux-m32r.org>,
Linux kernel mailing list <linux-kernel@vger.kernel.org>,
Ralf Baechle <ralf@linux-mips.org>,
Anders Kaseorg <andersk@MIT.EDU>,
Kyle McMartin <kyle@mcmartin.ca>,
Paul Mundt <lethal@linux-sh.org>,
linux-alpha@vger.kernel.org,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
uclinux-dist-devel@blackfin.uclinux.org,
Linus Torvalds <torvalds@linux-foundation.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v2 1/6] Add new macros for page-aligned data and bss sections.
Date: Fri, 01 May 2009 09:33:13 -0700 [thread overview]
Message-ID: <49FB2449.1010301@zytor.com> (raw)
In-Reply-To: <alpine.DEB.1.10.0905010951100.3955@vinegar-pot.mit.edu>
Tim Abbott wrote:
> On Fri, 1 May 2009, Sam Ravnborg wrote:
>
>> On Thu, Apr 30, 2009 at 03:54:08PM -0400, Tim Abbott wrote:
>>> +#define __PAGE_ALIGNED_DATA .section ".data.page_aligned", "aw", @progbits
>>> +#define __PAGE_ALIGNED_BSS .section ".bss.page_aligned", "aw", @nobits
>> It is my understanding that the linker will automatically
>> assume nobits for section names starting with .bss and likewise
>> progbits for section names starting with .data - so we can leave them out?
>
> I believe that is correct.
>
... but that doesn't mean it's the right thing to do.
It's better to be fully explicit when macroizing this kind of stuff.
This is part of why macroizing it is good: it means we end up with *one*
place that determines this stuff, not some magic heuristics in the linker.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2009-05-01 17:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-30 19:54 [PATCH v2 0/6] macros for section name cleanup Tim Abbott
2009-04-30 19:54 ` [PATCH v2 1/6] Add new macros for page-aligned data and bss sections Tim Abbott
2009-04-30 19:54 ` [PATCH v2 2/6] Add new NOSAVE_DATA linker script macro Tim Abbott
2009-04-30 19:54 ` [PATCH v2 3/6] Add new CACHELINE_ALIGNED_DATA " Tim Abbott
2009-04-30 19:54 ` [PATCH v2 4/6] Add new INIT_TASK_DATA() " Tim Abbott
2009-04-30 19:54 ` [PATCH v2 5/6] Add new READ_MOSTLY_DATA(align) " Tim Abbott
2009-04-30 19:54 ` [PATCH v2 6/6] Add support for __read_mostly to linux/cache.h Tim Abbott
2009-05-01 9:21 ` [PATCH v2 2/6] Add new NOSAVE_DATA linker script macro Sam Ravnborg
2009-05-01 9:18 ` [PATCH v2 1/6] Add new macros for page-aligned data and bss sections Sam Ravnborg
2009-05-01 13:54 ` Tim Abbott
2009-05-01 16:33 ` H. Peter Anvin [this message]
2009-05-01 17:17 ` Sam Ravnborg
2009-05-01 17:18 ` H. Peter Anvin
2009-05-01 17:44 ` Sam Ravnborg
2009-05-01 17:47 ` H. Peter Anvin
2009-05-01 23:02 ` Andreas Schwab
2009-05-01 9:04 ` [PATCH v2 0/6] macros for section name cleanup Sam Ravnborg
2009-05-01 14:21 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49FB2449.1010301@zytor.com \
--to=hpa@zytor.com \
--cc=andersk@MIT.EDU \
--cc=chris@zankel.net \
--cc=cooloney@kernel.org \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=dev-etrax@axis.com \
--cc=geert@linux-m68k.org \
--cc=gerg@uclinux.org \
--cc=gorcunov@openvz.org \
--cc=heiko.carstens@de.ibm.com \
--cc=hskinnemoen@atmel.com \
--cc=jbarnold@MIT.EDU \
--cc=jdike@addtoit.com \
--cc=jesper.nilsson@axis.com \
--cc=kyle@mcmartin.ca \
--cc=lethal@linux-sh.org \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=microblaze-uclinux@itee.uq.edu.au \
--cc=mingo@redhat.com \
--cc=monstr@monstr.eu \
--cc=paulus@samba.org \
--cc=ralf@linux-mips.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=rth@twiddle.net \
--cc=sam@ravnborg.org \
--cc=schwidefsky@de.ibm.com \
--cc=sparclinux@vger.kernel.org \
--cc=starvik@axis.com \
--cc=tabbott@MIT.EDU \
--cc=takata@linux-m32r.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=vda.linux@googlemail.com \
--cc=wdaher@MIT.EDU \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).