From: Timur Tabi <timur@freescale.com>
To: Jon Smirl <jonsmirl@gmail.com>
Cc: linuxppc-dev@ozlabs.org, alsa-devel@alsa-project.org,
broonie@sirena.org.uk
Subject: Re: [PATCH V5 3/5] AC97 driver for mpc5200
Date: Tue, 26 May 2009 09:09:43 -0500 [thread overview]
Message-ID: <4A1BF827.6010409@freescale.com> (raw)
In-Reply-To: <20090526123410.17472.15251.stgit@terra>
Jon Smirl wrote:
> +static void psc_ac97_warm_reset(struct snd_ac97 *ac97)
> +{
> + int rc;
> + struct mpc52xx_psc __iomem *regs = psc_dma->psc_regs;
> +
> + out_be32(®s->sicr, psc_dma->sicr | MPC52xx_PSC_SICR_AWR);
> + spin_event_timeout(0, 3, 0, rc);
I still think you should use udelay() here. spin_event_timeout(<constant>) will just reduce to a udelay() call anyway. In addition, there's no "event" that you're waiting for.
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2009-05-26 14:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-26 12:34 [PATCH V5 0/5] AC97 driver for mpc5200 Jon Smirl
2009-05-26 12:34 ` [PATCH V5 1/5] powerpc: introduce macro spin_event_timeout() Jon Smirl
2009-05-26 13:03 ` Mark Brown
2009-05-26 13:12 ` Jon Smirl
2009-05-26 14:53 ` [alsa-devel] " Mark Brown
2009-05-26 12:34 ` [PATCH V5 2/5] Main rewite of the mpc5200 audio DMA code Jon Smirl
2009-05-26 12:34 ` [PATCH V5 3/5] AC97 driver for mpc5200 Jon Smirl
2009-05-26 14:09 ` Timur Tabi [this message]
2009-05-26 12:34 ` [PATCH V5 4/5] Support for AC97 on Phytec pmc030 base board Jon Smirl
2009-05-26 12:34 ` [PATCH V5 5/5] Fabric bindings for STAC9766 on the Efika Jon Smirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A1BF827.6010409@freescale.com \
--to=timur@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@sirena.org.uk \
--cc=jonsmirl@gmail.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).