From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from az33egw02.freescale.net (az33egw02.freescale.net [192.88.158.103]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "az33egw02.freescale.net", Issuer "Thawte Premium Server CA" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id 2787FDDED0 for ; Wed, 27 May 2009 00:21:26 +1000 (EST) Message-ID: <4A1BFAA6.60309@freescale.com> Date: Tue, 26 May 2009 09:20:22 -0500 From: Timur Tabi MIME-Version: 1.0 To: Arnd Bergmann Subject: Re: [PATCH V4 1/5] The macro spin_event_timeout() takes a condition and timeout value References: <20090525221406.21370.30326.stgit@terra> <200905261349.49832.arnd@arndb.de> In-Reply-To: <200905261349.49832.arnd@arndb.de> Content-Type: text/plain; charset=ISO-8859-1 Cc: alsa-devel@alsa-project.org, linuxppc-dev@ozlabs.org, Geert Uytterhoeven , broonie@sirena.org.uk List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Arnd Bergmann wrote: > On Tuesday 26 May 2009, Geert Uytterhoeven wrote: >> However, you can still improve useability by making the macro return the rc, >> instead of letting the caller pass it, cfr. wait_event_timeout() and friends. I had that originally, but somewhere during the seven revisions of my macro, it got lost. I'll post a v9 soon. This version will take 3 parameters and return __ret, so Jon will need to change his code (sorry). -- Timur Tabi Linux kernel developer at Freescale