From: Geoff Thorpe <Geoff.Thorpe@freescale.com>
To: Timur Tabi <timur@freescale.com>
Cc: arnd@arndb.de, linuxppc-dev@ozlabs.org, geert.uytterhoeven@sonycom.com
Subject: Re: [PATCH 1/2] [PATCH 1/2 v9] powerpc: introduce macro spin_event_timeout()
Date: Tue, 26 May 2009 15:25:23 -0400 [thread overview]
Message-ID: <4A1C4223.3050401@freescale.com> (raw)
In-Reply-To: <1243351302-32062-2-git-send-email-timur@freescale.com>
Acked-by: Geoff Thorpe <Geoff.Thorpe@freescale.com>
Not sure that it's the most consistent formulation, but it's definitely
better than debating indefinitely.
Cheers,
Geoff
Timur Tabi wrote:
> The macro spin_event_timeout() takes a condition and timeout value
> (in microseconds) as parameters. It spins until either the condition is true
> or the timeout expires. It returns the result of the condition when the loop
> was terminated.
>
> This primary purpose of this macro is to poll on a hardware register until a
> status bit changes. The timeout ensures that the loop still terminates if the
> bit doesn't change as expected. This macro makes it easier for driver
> developers to perform this kind of operation properly.
>
> Signed-off-by: Timur Tabi <timur@freescale.com>
> ---
>
> v9: changed the macro to return the value, instead of having it passed in
[snip]
prev parent reply other threads:[~2009-05-26 19:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-26 15:21 [PATCH 0/2] [V2] introduce macro spin_event_timeout() Timur Tabi
2009-05-26 15:21 ` [PATCH 1/2] [PATCH 1/2 v9] powerpc: " Timur Tabi
2009-05-26 15:21 ` [PATCH 2/2] [PATCH 2/2 v2] qe: add polling timeout to qe_issue_cmd() Timur Tabi
2009-06-16 23:58 ` Kumar Gala
2009-05-26 19:25 ` Geoff Thorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A1C4223.3050401@freescale.com \
--to=geoff.thorpe@freescale.com \
--cc=arnd@arndb.de \
--cc=geert.uytterhoeven@sonycom.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).