From: Avi Kivity <avi@redhat.com>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: linuxppc-dev@ozlabs.org,
Andrew Morton <akpm@linux-foundation.org>,
paulmck@linux.vnet.ibm.com, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: powerpc: beyond ARRAY_SIZE of vcpu->arch.guest_tlb
Date: Sun, 31 May 2009 15:00:24 +0300 [thread overview]
Message-ID: <4A227158.6050605@redhat.com> (raw)
In-Reply-To: <4A15B129.8070700@gmail.com>
Roel Kluin wrote:
> Do not go beyond ARRAY_SIZE of vcpu->arch.guest_tlb
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> diff --git a/arch/powerpc/kvm/emulate.c b/arch/powerpc/kvm/emulate.c
> index 0fce4fb..c2cfd46 100644
> --- a/arch/powerpc/kvm/emulate.c
> +++ b/arch/powerpc/kvm/emulate.c
> @@ -125,7 +125,7 @@ static int kvmppc_emul_tlbwe(struct kvm_vcpu *vcpu, u32 inst)
> ws = get_ws(inst);
>
> index = vcpu->arch.gpr[ra];
> - if (index > PPC44x_TLB_SIZE) {
> + if (index >= PPC44x_TLB_SIZE) {
> printk("%s: index %d\n", __func__, index);
> kvmppc_dump_vcpu(vcpu);
> return EMULATE_FAIL;
>
This code no longer exists in kvm.git.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2009-05-31 12:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-21 19:53 [PATCH] KVM: powerpc: beyond ARRAY_SIZE of vcpu->arch.guest_tlb Roel Kluin
2009-05-31 12:00 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A227158.6050605@redhat.com \
--to=avi@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).