From: Heiko Schocher <hs@denx.de>
To: david@gibson.dropbear.id.au
Cc: linuxppc-dev@ozlabs.org
Subject: Re: 82xx, mgcoge: updates for 2.6.32
Date: Thu, 30 Jul 2009 07:29:46 +0200 [thread overview]
Message-ID: <4A712FCA.9070105@denx.de> (raw)
In-Reply-To: <20090729103203.GA6369@yookeroo.seuss>
Hello David,
David Gibson wrote:
> On Wed, Jul 29, 2009 at 10:32:30AM +0200, Heiko Schocher wrote:
>
> [snip]
>> + mdio@10d40 {
>> + device_type = "mdio";
>
> Drop this device_type.
Done.
>> + compatible = "fsl,cpm2-mdio-bitbang";
>> + reg = <0x10d00 0x14>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + fsl,mdio-pin = <12>;
>> + fsl,mdc-pin = <13>;
>> +
>> + phy0: ethernet-phy@0 {
>> + reg = <0x0>;
>> + device_type = "ethernet-phy";
>
> And this one, too.
Done.
>> + };
>> +
>> + phy1: ethernet-phy@1 {
>> + reg = <0x1>;
>> + device_type = "ethernet-phy";
>> + };
>> + };
>
I collect more comments, then the patch follows.
Thanks
bye
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2009-07-30 5:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-29 8:32 82xx, mgcoge: updates for 2.6.32 Heiko Schocher
2009-07-29 10:32 ` David Gibson
2009-07-30 5:29 ` Heiko Schocher [this message]
2009-08-03 7:34 ` [PATCH v2 1/2] " Heiko Schocher
2009-08-07 2:31 ` Kumar Gala
2009-07-29 13:40 ` Kumar Gala
2009-07-30 5:31 ` Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A712FCA.9070105@denx.de \
--to=hs@denx.de \
--cc=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).