[PATCH] powerpc: derive COMMAND_LINE_SIZE from asm-generic

[PATCH] powerpc: derive COMMAND_LINE_SIZE from asm-generic

[Paul Gortmaker]

The default COMMAND_LINE_SIZE in asm-generic is 512, so the
net effect of this change is nil, aside from the cleanup
factor.  See also commit 2b74b8569.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 arch/powerpc/include/asm/setup.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/powerpc/include/asm/setup.h b/arch/powerpc/include/asm/setup.h
index 817fac0..dae1934 100644
--- a/arch/powerpc/include/asm/setup.h
+++ b/arch/powerpc/include/asm/setup.h
@@ -1,6 +1,6 @@
 #ifndef _ASM_POWERPC_SETUP_H
 #define _ASM_POWERPC_SETUP_H
 
-#define COMMAND_LINE_SIZE	512
+#include <asm-generic/setup.h>
 
 #endif	/* _ASM_POWERPC_SETUP_H */
-- 
1.6.3.3

Re: [PATCH] powerpc: derive COMMAND_LINE_SIZE from asm-generic

[Arnd Bergmann]

On Thursday 13 August 2009 19:37:04 Paul Gortmaker wrote:
> The default COMMAND_LINE_SIZE in asm-generic is 512, so the
> net effect of this change is nil, aside from the cleanup
> factor.  See also commit 2b74b8569.
> 
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

Acked-by: Arnd Bergmann <arnd@arndb.de>

Just to clarify why this is good: There is a patch from Remis
to kbuild that can automatically create the trivial wrappers,
so we can remove arch/powerpc/include/asm/setup.h from the
kernel once that patch is applied.

I was also planning to submit a series to clean up more powerpc
in this way headers where applicable, see
http://git.kernel.org/?p=linux/kernel/git/arnd/asm-generic.git;a=shortlog;h=powerpc

The series needs some forward porting to 2.6.31 as well as testing.
If you or someone else wants to help with that, please go ahead!

Thanks,

	Arnd <><

Re: [PATCH] powerpc: derive COMMAND_LINE_SIZE from asm-generic

[Paul Gortmaker]

Arnd Bergmann wrote:
> On Thursday 13 August 2009 19:37:04 Paul Gortmaker wrote:
>> The default COMMAND_LINE_SIZE in asm-generic is 512, so the
>> net effect of this change is nil, aside from the cleanup
>> factor.  See also commit 2b74b8569.
>>
>> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> 
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> 
> Just to clarify why this is good: There is a patch from Remis
> to kbuild that can automatically create the trivial wrappers,
> so we can remove arch/powerpc/include/asm/setup.h from the
> kernel once that patch is applied.
> 
> I was also planning to submit a series to clean up more powerpc
> in this way headers where applicable, see
> http://git.kernel.org/?p=linux/kernel/git/arnd/asm-generic.git;a=shortlog;h=powerpc

I'd looked at master and next in your tree; I didn't
list all the branches and so I'd not noticed powerpc in there
as well.

> 
> The series needs some forward porting to 2.6.31 as well as testing.
> If you or someone else wants to help with that, please go ahead!

I'll definitely have a look at what is in there.

Paul.

> 
> Thanks,
> 
> 	Arnd <><