Re: [PATCH] sbc8560: Fix warm reboot with board specific reset function

[Paul Gortmaker <paul.gortmaker@windriver.com>]

Kumar Gala wrote:
> 
> On Aug 13, 2009, at 6:06 PM, Paul Gortmaker wrote:
> 
>> From: Liang Li <Liang.Li@windriver.com>
>>
>> The existing fsl_rstcr_restart function fails to reset the sbc8560
>> board. This implements a board specific reset function that uses
>> the RCR(Reset Control Register) of the board's EPLD to do a reset.
>>
>> Signed-off-by: Liang Li <Liang.Li@windriver.com>
>> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
>> ---
>> arch/powerpc/platforms/85xx/sbc8560.c |   39 
>> ++++++++++++++++++++++++++++++++-
>> 1 files changed, 38 insertions(+), 1 deletions(-)
> 
> The reason it didn't was that feature doesnt exist on the mpc8560 :)

I could see how that might have an impact on the
functionality.... :-)

So, what should the guts block of the 8560 dts look
like? It currently has the standard:

------------
global-utilities@e0000 {
   compatible = "fsl,mpc8560-guts";
   reg = <0xe0000 0x1000>;
   fsl,has-rstcr;
};
------------

MPC8560 has a guts block, but saying "has-rstcr", as
you've pointed out, is a bit of a lie. If we remove that
tag, then we'll trip the:

 printk(KERN_INFO "rstcr compatible register does not exist!\n");

which isn't the end of the world, but at the moment it
reads more like an error message, vs. an informative one.

Paul.

> 
> - k