From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id ABFB9B7088 for ; Sat, 12 Sep 2009 01:59:28 +1000 (EST) Received: from mail3.caviumnetworks.com (mail3.caviumnetworks.com [12.108.191.235]) by ozlabs.org (Postfix) with ESMTP id 0B560DDD01 for ; Sat, 12 Sep 2009 01:59:27 +1000 (EST) Message-ID: <4AAA73A4.9010601@caviumnetworks.com> Date: Fri, 11 Sep 2009 08:58:28 -0700 From: David Daney MIME-Version: 1.0 To: Michael Buesch Subject: Re: [PATCH 01/10] Add support for GCC-4.5's __builtin_unreachable() to compiler.h References: <4AA991C1.1050800@caviumnetworks.com> <1252627011-2933-1-git-send-email-ddaney@caviumnetworks.com> <200909111633.00665.mb@bu3sch.de> In-Reply-To: <200909111633.00665.mb@bu3sch.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: linux-mips@linux-mips.org, Heiko Carstens , linuxppc-dev@ozlabs.org, Paul Mackerras , "H. Peter Anvin" , linux-s390@vger.kernel.org, linux-am33-list@redhat.com, Helge Deller , x86@kernel.org, Ingo Molnar , Mike Frysinger , Ivan Kokshaysky , linux390@de.ibm.com, Thomas Gleixner , Richard Henderson , Haavard Skinnemoen , linux-parisc@vger.kernel.org, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, ralf@linux-mips.org, Kyle McMartin , linux-alpha@vger.kernel.org, Martin Schwidefsky , uclinux-dist-devel@blackfin.uclinux.org, akpm@linux-foundation.org, Koichi Yasutake , linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Michael Buesch wrote: > On Friday 11 September 2009 01:56:42 David Daney wrote: >> +/* Unreachable code */ >> +#ifndef unreachable >> +# define unreachable() do { for (;;) ; } while (0) >> +#endif > > # define unreachable() do { } while (1) > > ? :) Clearly I was not thinking clearly when I wrote that part. RTH noted the same thing. I will fix it. Thanks, David Daney