From: Scott Wood <scottwood@freescale.com>
To: Joakim Tjernlund <joakim.tjernlund@transmode.se>
Cc: "linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>,
Rex Feany <RFeany@mrv.com>
Subject: Re: [PATCH 0/8] 8xx: Misc fixes for buggy insn
Date: Tue, 10 Nov 2009 10:36:37 -0600 [thread overview]
Message-ID: <4AF99695.800@freescale.com> (raw)
In-Reply-To: <OF0C254AE9.CCCFDCCC-ONC125766A.002D331C-C125766A.002E7C69@transmode.se>
Joakim Tjernlund wrote:
> Scott Wood <scottwood@freescale.com> wrote on 10/11/2009 00:00:04:
>> syscall_exit_cont, SRR0/SRR1 were being loaded immediately prior to a page
>> boundary, with the rfi after the page boundary. On crossing the boundary,
>> we take an ITLB miss (which goes from possibility to certainty with the
>> CPU15 workaround), and SRR0/SRR1 get clobbered.
>
> I am not familiar with CPU15 since we never had that problem.
> The patch series is OK then, but one need to add some CPU15 love?
It's not CPU15 itself that is causing the problem, but rather the
workaround for CPU15 takes something that has a possibility of happening
and makes it certain to happen.
>> Either that, or require that the kernel text be pinned, though that does not
>> interact well with CPU15.
>
> Why does not pinning interact well with CPU15? If pinned, you never get
> a TLB miss for kernel text so that should mitigate the CPU15 problem.
The nature of the workaround for CPU15 is that we can't keep it pinned
-- we have to take an ITLB miss on every page boundary crossing. If you
try to pin, it'll just be invalidated by the workaround.
There is an alternate workaround, but it requires compiler changes.
-Scott
next prev parent reply other threads:[~2009-11-10 16:36 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-04 13:38 [PATCH 0/8] 8xx: Misc fixes for buggy insn Joakim Tjernlund
2009-11-04 13:38 ` [PATCH 1/8] 8xx: invalidate non present TLBs Joakim Tjernlund
2009-11-04 13:38 ` [PATCH 2/8] 8xx: Update TLB asm so it behaves as linux mm expects Joakim Tjernlund
2009-11-04 13:38 ` [PATCH 3/8] 8xx: Tag DAR with 0x00f0 to catch buggy instructions Joakim Tjernlund
2009-11-04 13:38 ` [PATCH 4/8] 8xx: Fixup DAR from buggy dcbX instructions Joakim Tjernlund
2009-11-04 13:38 ` [PATCH 5/8] 8xx: Add missing Guarded setting in DTLB Error Joakim Tjernlund
2009-11-04 13:38 ` [PATCH 6/8] 8xx: Restore _PAGE_WRITETHRU Joakim Tjernlund
2009-11-04 13:38 ` [PATCH 7/8] 8xx: start using dcbX instructions in various copy routines Joakim Tjernlund
2009-11-04 13:38 ` [PATCH 8/8] 8xx: Remove DIRTY pte handling in DTLB Error Joakim Tjernlund
2009-11-06 0:33 ` [PATCH 0/8] 8xx: Misc fixes for buggy insn Scott Wood
2009-11-06 8:01 ` Joakim Tjernlund
2009-11-06 9:29 ` Joakim Tjernlund
[not found] ` <20091109215321.GA4351@loki.buserror.net>
2009-11-09 23:00 ` Scott Wood
2009-11-10 8:27 ` Joakim Tjernlund
2009-11-10 16:36 ` Scott Wood [this message]
2009-11-10 16:55 ` Scott Wood
2009-11-10 19:08 ` Joakim Tjernlund
[not found] ` <4AF9CC99.1030500@freescale.com>
2009-11-10 21:25 ` Joakim Tjernlund
[not found] ` <4AF9DCE0.4030805@freescale.com>
2009-11-10 21:47 ` Joakim Tjernlund
2009-11-10 22:02 ` Scott Wood
2009-11-10 23:15 ` Joakim Tjernlund
2009-11-10 23:21 ` Scott Wood
2009-11-11 0:06 ` Joakim Tjernlund
2009-11-11 15:26 ` Scott Wood
2009-11-12 9:10 ` Joakim Tjernlund
2009-11-12 19:45 ` Scott Wood
2009-11-12 21:14 ` Joakim Tjernlund
2009-11-12 21:57 ` Scott Wood
2009-11-12 23:29 ` Joakim Tjernlund
2009-11-13 19:25 ` Scott Wood
2009-11-14 14:11 ` Joakim Tjernlund
2009-11-10 19:54 ` Joakim Tjernlund
[not found] ` <4AF9C647.50600@freescale.com>
2009-11-10 21:05 ` Joakim Tjernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AF99695.800@freescale.com \
--to=scottwood@freescale.com \
--cc=RFeany@mrv.com \
--cc=joakim.tjernlund@transmode.se \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).