From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from proxy3.bredband.net (proxy3.bredband.net [195.54.101.73]) by ozlabs.org (Postfix) with ESMTP id BB275B7B8F for ; Fri, 13 Nov 2009 04:43:10 +1100 (EST) Received: from ipb1.telenor.se (195.54.127.164) by proxy3.bredband.net (7.3.140.3) id 4AD3E1BA00CCCE67 for linuxppc-dev@ozlabs.org; Thu, 12 Nov 2009 18:22:40 +0100 Message-ID: <4AFC4460.9050508@mocean-labs.com> Date: Thu, 12 Nov 2009 18:22:40 +0100 From: =?ISO-8859-1?Q?Richard_R=F6jfors?= MIME-Version: 1.0 To: John Linn Subject: Re: [PATCH v2 1/4] xilinx_spi: Split into of driver and generic part. References: <4AFC1B1E.60304@mocean-labs.com> <38eacaec-f0d3-436c-b461-40b5d795cdd9@VA3EHSMHS009.ehs.local> In-Reply-To: <38eacaec-f0d3-436c-b461-40b5d795cdd9@VA3EHSMHS009.ehs.local> Content-Type: text/plain; charset=ISO-8859-1 Cc: spi-devel-general@lists.sourceforge.net, Andrew Morton , dbrownell@users.sourceforge.net, linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 11/12/09 6:17 PM, John Linn wrote: >> Have you compile tested this? platform_data is a void*, the >> dereference will not work. I know you don't have hardware; but >> getting the needed cross compiler is easy. > > Here's the fixes I did to make it compile. On to testing :) Great! I tested this against a max7301 GPIO expander. --Richard