From: Tejun Heo <tj@kernel.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linux-ide@vger.kernel.org, Holger Macht <hmacht@suse.de>,
linuxppc-dev@lists.ozlabs.org, Jeff Garzik <jeff@garzik.org>
Subject: Re: [PATCH 5/5] libata/drivers: Add pata_macio, driver Apple PowerMac/PowerBook IDE controller
Date: Wed, 02 Dec 2009 08:44:15 +0900 [thread overview]
Message-ID: <4B15AA4F.5040309@kernel.org> (raw)
In-Reply-To: <1259710543.2076.1054.camel@pasglop>
On 12/02/2009 08:35 AM, Benjamin Herrenschmidt wrote:
> On Wed, 2009-12-02 at 08:27 +0900, Tejun Heo wrote:
>> Conceptually freeze would be more approriate but the side effect is
>> that the port is frozen and EH will try to thaw it by resetting it.
>> So, abort would work better.
>
> BTW. For a plug event, what should I do ? freeze is fine ? Or just
> schedule eh ? Right now, when plugging I see an exception Emask 0x10
> etc... message in the log when plugging which isn't totally nice :-)
freeze() and please don't fight the EH messages from low level driver.
If it's too much, we need to update core layer but given the variety
of phy related bugs, I think we need those messages.
Thanks.
--
tejun
next prev parent reply other threads:[~2009-12-01 23:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-01 7:08 [PATCH 5/5] libata/drivers: Add pata_macio, driver Apple PowerMac/PowerBook IDE controller Benjamin Herrenschmidt
2009-12-01 8:00 ` Tejun Heo
2009-12-01 12:44 ` Holger Macht
2009-12-01 12:48 ` Tejun Heo
2009-12-01 23:19 ` Benjamin Herrenschmidt
2009-12-01 23:27 ` Tejun Heo
2009-12-01 23:35 ` Benjamin Herrenschmidt
2009-12-01 23:44 ` Tejun Heo [this message]
2009-12-02 0:00 ` Benjamin Herrenschmidt
2009-12-01 10:48 ` Mikael Pettersson
2009-12-01 10:53 ` Benjamin Herrenschmidt
2009-12-01 20:43 ` Andreas Schwab
2009-12-01 22:34 ` Benjamin Herrenschmidt
2009-12-01 22:58 ` Benjamin Herrenschmidt
-- strict thread matches above, loose matches on Subject: below --
2009-12-02 0:36 Benjamin Herrenschmidt
2009-12-02 1:07 ` Tejun Heo
2009-12-02 1:51 ` Benjamin Herrenschmidt
2009-12-02 1:55 ` Tejun Heo
2009-12-02 11:44 ` Andreas Schwab
2009-12-03 8:12 ` Jeff Garzik
2009-12-03 23:55 ` Benjamin Herrenschmidt
2009-12-03 15:10 ` Mikael Pettersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B15AA4F.5040309@kernel.org \
--to=tj@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=hmacht@suse.de \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).