From: Scott Wood <scottwood@freescale.com>
To: Mark Ware <mware@elphinstone.net>
Cc: Linuxppc-dev Development <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH] cpm2_pic: Allow correct flow_types for port C interrupts
Date: Tue, 08 Dec 2009 17:09:11 -0600 [thread overview]
Message-ID: <4B1EDC97.6010301@freescale.com> (raw)
In-Reply-To: <4B1ED995.4060802@elphinstone.net>
Mark Ware wrote:
> Mark Ware wrote:
>> CPM2 Port C interrupts can be either falling edge, or either edge.
>> Other external interrupts are either falling edge or active low.
[snip]
>> + /* Port C interrupts are either IRQ_TYPE_EDGE_FALLING or
>> + * IRQ_TYPE_EDGE_BOTH (default). All others are IRQ_TYPE_EDGE_FALLING
>> + * or IRQ_TYPE_LEVEL_LOW (default)
>> + */
>> + if (src >= CPM2_IRQ_PORTC15 && src <= CPM2_IRQ_PORTC0) {
>> + if (flow_type == IRQ_TYPE_NONE)
>> + flow_type = IRQ_TYPE_EDGE_BOTH;
>> +
>> + if (flow_type & ~IRQ_TYPE_EDGE_BOTH) {
>> + printk(KERN_ERR "CPM2 PIC: sense type 0x%x not supported\n",
>> + flow_type);
>> + return -EINVAL;
>> + }
The above code looks like it would allow rising-only, which according to
the changelog isn't supported.
-Scott
next prev parent reply other threads:[~2009-12-08 23:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-25 2:15 [PATCH] cpm2_pic: Allow correct flow_types for port C interrupts Mark Ware
2009-12-08 22:56 ` Mark Ware
2009-12-08 23:09 ` Scott Wood [this message]
2009-12-08 23:41 ` Mark Ware
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B1EDC97.6010301@freescale.com \
--to=scottwood@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=mware@elphinstone.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).