From: Mark Ware <mware@elphinstone.net>
To: Scott Wood <scottwood@freescale.com>
Cc: Linuxppc-dev Development <linuxppc-dev@ozlabs.org>,
avorontsov@ru.mvista.com
Subject: Re: [PATCH v2] cpm2_pic: Allow correct flow_types for port C interrupts
Date: Thu, 10 Dec 2009 22:10:16 +1100 [thread overview]
Message-ID: <4B20D718.9050204@elphinstone.net> (raw)
In-Reply-To: <4B201D67.4070802@freescale.com>
Scott Wood wrote:
> Anton Vorontsov wrote:
>>> + if ((flow_type != IRQ_TYPE_EDGE_BOTH) && +
>>> (flow_type != IRQ_TYPE_EDGE_FALLING)) {
>>
>> I'd place one more tab here.
>
> Or better, align one "flow_type" with the other.
>
> -Scott
>
Thanks Anton and Scott.
Scott's suggestion is also my preferred style, but a (brief) search through the source didn't reveal much support.
I'll send a new version shortly including you suggestions.
- Mark
prev parent reply other threads:[~2009-12-10 11:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-09 0:48 [PATCH v2] cpm2_pic: Allow correct flow_types for port C interrupts Mark Ware
2009-12-09 20:43 ` Kumar Gala
2009-12-09 21:53 ` Anton Vorontsov
2009-12-09 21:57 ` Scott Wood
2009-12-10 11:10 ` Mark Ware [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B20D718.9050204@elphinstone.net \
--to=mware@elphinstone.net \
--cc=avorontsov@ru.mvista.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).