From: Bill Gatliff <bgat@billgatliff.com>
To: Linux/PPC Development <linuxppc-dev@ozlabs.org>
Subject: Question on MPC52xx IRQ[123] pins
Date: Mon, 21 Dec 2009 16:30:54 -0600 [thread overview]
Message-ID: <4B2FF71E.10508@billgatliff.com> (raw)
Guys:
I think I already know the answer to this, having read most of the
MPC52xx manual. But I'll ask anyway, just to be sure I'm not missing
something obvious... :)
Is it possible to treat the external IRQ[123] pins on the MPC52xx as
GPIO inputs? And if so, how do I tweak my dts file and other code, if
necessary, to make that happen?
Reason I ask is, I'm trying to enhance
drivers/input/misc/rotary-encoder.c to use device trees, and one of the
encoder inputs is on IRQ2. My strategy so far is to just provide an
of_probe() function that builds a rotary_encoder_platform_data structure
and then calls platform_device_register(). And that ain't working. :)
First off, the rotary-encoder driver assumes that both of its inputs are
both known to gpiolib, so that they can do both gpio_to_irq() and
gpio_get_value() on them. There isn't any existing code that I can find
that allows you to read the states of IRQ pins, be it under gpiolib or
otherwise. And I think the reason for that is that there's no way to
actually read the states of those pins at all--- the hardware just
doesn't work that way.
Or am I missing something?
Second, if I get all this working then my rotary encoders won't be
platform devices--- they'll be openfirmware devices, which means I'll
have to do other work in the code as well. That's a subtle point I
know, but rotary-encoder's assumption that all rotary encoder devices
are also platform devices is kind of like mixing policy with
implementation, it turns out. Almost like trying to reuse a PCI driver
as a platform driver. I didn't spot how important that was until I
started hacking on the code itself...
Thanks!
b.g.
--
Bill Gatliff
bgat@billgatliff.com
next reply other threads:[~2009-12-21 22:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-21 22:30 Bill Gatliff [this message]
2009-12-21 23:16 ` Question on MPC52xx IRQ[123] pins Grant Likely
2009-12-31 14:34 ` Bill Gatliff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B2FF71E.10508@billgatliff.com \
--to=bgat@billgatliff.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox