From: Micha Nelissen <micha@neli.hopto.org>
To: Alexandre Bounine <alexb@tundra.com>
Cc: linux-kernel@vger.kernel.org, thomas.moll@sysgo.com,
linuxppc-dev@lists.ozlabs.org, alexandreb@tundra.com,
thomas.moll.ext@nsn.com
Subject: Re: [PATCH 1/7] RapidIO: Add IDT CPS/TSI switches
Date: Wed, 24 Feb 2010 21:02:38 +0100 [thread overview]
Message-ID: <4B8585DE.50701@neli.hopto.org> (raw)
In-Reply-To: <20100224151447.GA13661@kaneng01.tundra.com>
Alexandre Bounine wrote:
> @@ -369,6 +380,10 @@ static struct rio_dev __devinit *rio_set
> rdev->rswitch->switchid);
> rio_route_set_ops(rdev);
>
> + if (do_enum && rdev->rswitch->clr_table)
> + rdev->rswitch->clr_table(port, destid, hopcount,
> + RIO_GLOBAL_TABLE);
> +
> list_add_tail(&rswitch->node, &rio_switches);
>
> } else
Why clear the tables here, why not in rio_enum_peer?
> +DECLARE_RIO_ROUTE_OPS(RIO_VID_TUNDRA, RIO_DID_TSI572, tsi57x_route_add_entry, tsi57x_route_get_entry, tsi57x_route_clr_table);
> +DECLARE_RIO_ROUTE_OPS(RIO_VID_TUNDRA, RIO_DID_TSI574, tsi57x_route_add_entry, tsi57x_route_get_entry, tsi57x_route_clr_table);
> +DECLARE_RIO_ROUTE_OPS(RIO_VID_TUNDRA, RIO_DID_TSI577, tsi57x_route_add_entry, tsi57x_route_get_entry, tsi57x_route_clr_table);
> +DECLARE_RIO_ROUTE_OPS(RIO_VID_TUNDRA, RIO_DID_TSI578, tsi57x_route_add_entry, tsi57x_route_get_entry, tsi57x_route_clr_table);
Can the 568 and 578 driver be shared? Have a 5xx driver?
Micha
next prev parent reply other threads:[~2010-02-24 20:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-24 15:14 [PATCH 1/7] RapidIO: Add IDT CPS/TSI switches Alexandre Bounine
2010-02-24 20:02 ` Micha Nelissen [this message]
2010-02-25 14:18 ` Bounine, Alexandre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B8585DE.50701@neli.hopto.org \
--to=micha@neli.hopto.org \
--cc=alexandreb@tundra.com \
--cc=alexb@tundra.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=thomas.moll.ext@nsn.com \
--cc=thomas.moll@sysgo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox