From: Micha Nelissen <micha@neli.hopto.org>
To: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 2/7] RapidIO: Add switch locking during discovery
Date: Thu, 25 Feb 2010 20:11:08 +0100 [thread overview]
Message-ID: <4B86CB4C.2070406@neli.hopto.org> (raw)
In-Reply-To: <0CE8B6BE3C4AD74AB97D9D29BD24E552A54EA1@CORPEXCH1.na.ads.idt.com>
Bounine, Alexandre wrote:
> Micha Nelissen wrote:
>> Alexandre Bounine wrote:
>>> + mport->host_deviceid = RIO_GET_DID(mport->sys_size,
>> This fixes something else, should be a separate patch.
>
> This sets an ID used for locking during discovery. On a startup only
> enumerator's ID is set to the specified value. All discovering agents
Ah I see. Isn't it a bit ugly to have "host_deviceid" being the device's
own destid?
I have removed mport->host_deviceid, and added rdev_host and rdev_self
to rio_net. I also added code to create a rio device for the "self"
instance; then the locking would always use net->rdev_self->destid.
Micha
prev parent reply other threads:[~2010-02-25 19:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-24 15:20 [PATCH 2/7] RapidIO: Add switch locking during discovery Alexandre Bounine
2010-02-24 19:15 ` Micha Nelissen
[not found] ` <4B857A53.30106@neli.hopto.org>
2010-02-25 14:53 ` Bounine, Alexandre
2010-02-25 19:11 ` Micha Nelissen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B86CB4C.2070406@neli.hopto.org \
--to=micha@neli.hopto.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox