Re: [PATCH 7/7] powerpc/85xx: Fix the RapidIO maintenance access functions

[Micha Nelissen <micha@neli.hopto.org>]

Bounine, Alexandre wrote:
> Hi Micha,
> 
> I tested it on my setup - it works.
> Maybe Thomas may give more details on this change.

Did you (for fun) try once to decrease the maintenance window to say, 4 
kB? Then you really need these "high" bits to work properly.

Or did you try with some register at offset > 4MB? The Tundra's have 
registers going up to 0x14000 or so? So don't need 16MB addressing for that.

Thanks, Micha


>> -----Original Message-----
>> From: Micha Nelissen [mailto:micha@neli.hopto.org]
>> Sent: Wednesday, February 24, 2010 3:21 PM
>> To: Alexandre Bounine
>> Subject: Re: [PATCH 7/7] powerpc/85xx: Fix the RapidIO maintenance
> access functions
>> Alexandre Bounine wrote:
>>>  	out_be32(&priv->maint_atmu_regs->rowtar,
>>> -		 (destid << 22) | (hopcount << 12) | ((offset & ~0x3) >>
> 9));
>>> +		 (destid << 22) | (hopcount << 12) | (offset >> 12));
>>> +	out_be32(&priv->maint_atmu_regs->rowtear,  (destid >> 10));
>> Did this actually work for you? The (offset >> 12) is due to the 4MB
>> window size right?
>>
>> Micha
>