From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH] 8250: add workaround for MPC8[356]xx UART break IRQ storm
Date: Fri, 26 Feb 2010 15:21:15 -0500 [thread overview]
Message-ID: <4B882D3B.5050003@windriver.com> (raw)
In-Reply-To: <EB2B2912-24C3-46C9-B894-0A84D593570F@kernel.crashing.org>
On 10-02-26 02:42 PM, Kumar Gala wrote:
>
> On Feb 26, 2010, at 1:25 PM, Paul Gortmaker wrote:
>
[...]
>>
>> + if ((up->bugs& UART_BUG_PPC)&& (status == UART_LSR_RFE_ERROR_BITS)) {
>> + spin_unlock_irqrestore(&up->port.lock, flags);
>> + return;
>> + }
>> +
[...]
>
> is there harm caused if we have SERIAL_8250_PPC_BUG set and dont need it?
In theory, no -- strip away all the window dressing and we are
left with the above change. So, you'd have to have some UART
implementation that was setting those bits and still relying
on its interrupt event to be processed normally. But since
there are so many different 8250 implementations out there,
I was being cautious and taking the absolute safe approach.
P.
>
> - k
next prev parent reply other threads:[~2010-02-26 20:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-26 19:25 [PATCH] 8250: add workaround for MPC8[356]xx UART break IRQ storm Paul Gortmaker
2010-02-26 19:42 ` Kumar Gala
2010-02-26 20:21 ` Paul Gortmaker [this message]
2010-02-26 20:23 ` Scott Wood
2010-03-01 21:23 ` Paul Gortmaker
2010-03-01 23:03 ` vb
2010-03-02 16:27 ` Paul Gortmaker
2010-03-02 21:21 ` vb
2011-11-24 8:14 ` Kumar Gala
2011-11-24 15:26 ` Paul Gortmaker
2011-11-24 19:07 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B882D3B.5050003@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=galak@kernel.crashing.org \
--cc=linux-serial@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).