From: Scott Wood <scottwood@freescale.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Detlev Zundel <dzu@denx.de>,
Markus Fischer <markus.fischer.ec@ifm.com>,
devicetree-discuss@lists.ozlabs.org,
Michael Weiss <michael.weiss@ifm.com>,
linuxppc-dev@ozlabs.org, Anatolij Gustschin <agust@denx.de>,
Wolfgang Grandegger <wg@denx.de>
Subject: Re: [PATCH 2/2] powerpc/mpc5121: add initial support for PDM360NG board
Date: Mon, 03 May 2010 11:34:27 -0500 [thread overview]
Message-ID: <4BDEFB13.5060407@freescale.com> (raw)
In-Reply-To: <g2tfa686aa41005020754t46934f13hbd5c75a6b7668a54@mail.gmail.com>
Grant Likely wrote:
>> + // IPIC
>> + // interrupts cell = <intr #, sense>
>> + // sense values match linux IORESOURCE_IRQ_* defines:
>> + // sense == 8: Level, low assertion
>> + // sense == 2: Edge, high-to-low change
>> + //
>> + ipic: interrupt-controller@c00 {
>> + compatible = "fsl,mpc5121-ipic", "fsl,ipic";
>> + interrupt-controller;
>> + #address-cells = <0>;
>
> Don't need #address-cells here
#address-cells is required by ePAPR for interrupt controllers if an
interrupt-map is used. While there isn't one in this tree, it's best to
just always include #address-cells in interrupt controller nodes.
-Scott
next prev parent reply other threads:[~2010-05-03 16:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-30 20:30 [PATCH 1/2] powerpc/mpc512x: Group mpc512x board's selection menu Anatolij Gustschin
2010-04-30 20:30 ` [PATCH 2/2] powerpc/mpc5121: add initial support for PDM360NG board Anatolij Gustschin
2010-05-02 14:54 ` Grant Likely
2010-05-03 9:22 ` Anatolij Gustschin
2010-05-03 16:34 ` Scott Wood [this message]
2010-05-19 21:27 ` Grant Likely
2010-05-19 21:37 ` Scott Wood
2010-05-19 21:47 ` Grant Likely
2010-06-22 21:39 ` Scott Wood
2010-05-03 10:23 ` [PATCH v2 " Anatolij Gustschin
2010-07-23 13:49 ` [PATCH v3 " Anatolij Gustschin
2010-07-25 7:42 ` Grant Likely
2010-07-27 10:36 ` Anatolij Gustschin
2010-07-27 16:58 ` Grant Likely
2010-07-27 17:28 ` Anatolij Gustschin
2010-07-27 17:43 ` Grant Likely
2010-07-27 21:26 ` [PATCH v4 " Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BDEFB13.5060407@freescale.com \
--to=scottwood@freescale.com \
--cc=agust@denx.de \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dzu@denx.de \
--cc=grant.likely@secretlab.ca \
--cc=linuxppc-dev@ozlabs.org \
--cc=markus.fischer.ec@ifm.com \
--cc=michael.weiss@ifm.com \
--cc=wg@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).