From: Brian King <brking@linux.vnet.ibm.com>
To: michael@ellerman.id.au
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 1/2] powerpc: Partition hibernation support
Date: Mon, 10 May 2010 15:57:35 -0500 [thread overview]
Message-ID: <4BE8733F.5080905@linux.vnet.ibm.com> (raw)
In-Reply-To: <4BE81A3E.8030501@linux.vnet.ibm.com>
On 05/10/2010 09:37 AM, Brian King wrote:
>
>>> }
>>> #else /* CONFIG_PPC_PSERIES */
>>> static int rtas_ibm_suspend_me(struct rtas_args *args)
>>> {
>>> return -ENOSYS;
>>> }
>>> +
>>> +int rtas_suspend_cpu(struct rtas_suspend_me_data *data)
>>> +{
>>> + return -ENOSYS;
>>> +}
>>> +
>>> +int rtas_suspend_last_cpu(struct rtas_suspend_me_data *data)
>>> +{
>>> + return -ENOSYS;
>>> +}
>>
>> Don't see why you need these empty versions, they're only ever called
>> from pseries code aren't they?
>
> True, but we still need to be able to link the code in a cross platform
> kernel.
I was able to fix this up as well with a makefile change to ensure
suspend.c only gets built when CONFIG_PPC_PSERIES=y
--
Brian King
Linux on Power Virtualization
IBM Linux Technology Center
next prev parent reply other threads:[~2010-05-10 20:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 18:58 [PATCH 1/2] powerpc: Partition hibernation support Brian King
2010-05-10 6:48 ` Michael Ellerman
2010-05-10 14:37 ` Brian King
2010-05-10 20:57 ` Brian King [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-02-24 0:02 Brian King
2010-03-11 19:59 ` Nathan Fontenot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BE8733F.5080905@linux.vnet.ibm.com \
--to=brking@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=michael@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).