linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: Andreas Schwab <schwab@redhat.com>
Cc: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH] powerpc: Don't export cvt_fd & _df when CONFIG_PPC_FPU is not set
Date: Mon, 31 May 2010 17:52:29 +0200	[thread overview]
Message-ID: <4C03DB3D.7090007@suse.de> (raw)
In-Reply-To: <m3ljb0tn2l.fsf@hase.home>

Andreas Schwab wrote:
> Alexander Graf <agraf@suse.de> writes:
>
>   
>> On 31.05.2010, at 04:00, Benjamin Herrenschmidt wrote:
>>
>>     
>>> On Mon, 2010-05-31 at 11:50 +1000, Benjamin Herrenschmidt wrote:
>>>       
>>>> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>>>> ---
>>>> arch/powerpc/kernel/ppc_ksyms.c |    2 +-
>>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>>         
>>> Alex, this is just a temporary fix to remove the build breakage for 40x
>>> etc... but please, update KVM to just build-in its own.
>>>       
>> What's the bad part in reusing the existing code?
>>     
>
> The bad part is that KVM is wasting a ridiculous amount of stack space
> by allocating multiple instances of struct task_struct on it.  I have a
> patch removing all of it, but I haven't tested it yet.
>   

Mind to send it over so I can take a look at it :)? Getting rid of the
task_struct structs lying in the stack is certainly a good idea.

Alex

  reply	other threads:[~2010-05-31 15:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-31  1:50 [PATCH] powerpc: Don't export cvt_fd & _df when CONFIG_PPC_FPU is not set Benjamin Herrenschmidt
2010-05-31  2:00 ` Benjamin Herrenschmidt
2010-05-31  9:33   ` Alexander Graf
2010-05-31  9:52     ` Andreas Schwab
2010-05-31 15:52       ` Alexander Graf [this message]
     [not found]       ` <4C03DB3D.7090007__38063.9078132392$1275321190$gmane$org@suse.de>
2010-05-31 18:06         ` Andreas Schwab
2010-05-31 18:52           ` Alexander Graf
2010-06-01  9:31           ` Benjamin Herrenschmidt
     [not found]           ` <1275384716.1931.711.camel__10281.3212587082$1275384770$gmane$org@pasglop>
2010-06-01  9:36             ` Andreas Schwab
2010-06-01  9:46               ` Benjamin Herrenschmidt
     [not found]               ` <1275385607.1931.712.camel__30394.2679115154$1275385651$gmane$org@pasglop>
2010-06-01 15:58                 ` [PATCH] macio: don't dereference pointer before null check Andreas Schwab
     [not found]             ` <m3mxvfrt5n.fsf__49359.5060579993$1275385036$gmane$org@hase.home>
2010-06-01 18:58               ` [PATCH] powerpc: Don't export cvt_fd & _df when CONFIG_PPC_FPU is not set Andreas Schwab
2010-06-02  7:11                 ` Benjamin Herrenschmidt
2010-05-31 10:24     ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C03DB3D.7090007@suse.de \
    --to=agraf@suse.de \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=schwab@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).