From: "Steven A. Falco" <sfalco@harris.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH][RFC] ibm_newemac and SIOCGMIIREG
Date: Thu, 10 Jun 2010 17:26:52 -0400 [thread overview]
Message-ID: <4C11589C.7060108@harris.com> (raw)
In-Reply-To: <201006102235.48632.arnd@arndb.de>
On 06/10/2010 04:35 PM, Arnd Bergmann wrote:
>
> It seems that your program is wrong. On my PC here, it also shows zero,
> while mii-tool works fine.
>
You are correct. I didn't realize I should embed the data
in the ifr_data area - I thought I needed to pass a pointer.
Now I see why you avoid that. And since IFNAMSIZ is 16,
there is enough space for the struct mii_ioctl_data. A bit
dirty, but it obviously works.
Anyway, thanks very much for taking the time to debug my
program, and set me straight. Naturally, I withdraw the
patch. :-)
Steve
>
> Arnd
prev parent reply other threads:[~2010-06-10 21:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-10 14:00 [PATCH][RFC] ibm_newemac and SIOCGMIIREG Steven A. Falco
2010-06-10 14:31 ` Arnd Bergmann
2010-06-10 15:27 ` Steven A. Falco
2010-06-10 17:03 ` Arnd Bergmann
2010-06-10 19:47 ` Steven A. Falco
2010-06-10 20:35 ` Arnd Bergmann
2010-06-10 21:26 ` Steven A. Falco [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C11589C.7060108@harris.com \
--to=sfalco@harris.com \
--cc=arnd@arndb.de \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).