From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by ozlabs.org (Postfix) with ESMTP id 8AF25B6F15 for ; Tue, 22 Jun 2010 22:20:46 +1000 (EST) Message-ID: <4C20AA9B.8000807@redhat.com> Date: Tue, 22 Jun 2010 15:20:43 +0300 From: Avi Kivity MIME-Version: 1.0 To: Alexander Graf Subject: Re: [PATCH 1/2] KVM: PPC: Add generic hpte management functions References: <1277127841-32704-1-git-send-email-agraf@suse.de> <4C20A64D.2070805@redhat.com> <4C20A6C8.4070002@suse.de> <4C20A795.6040607@redhat.com> <4C20A836.2010908@suse.de> <4C20A890.9040806@redhat.com> <4C20A91A.1080607@suse.de> In-Reply-To: <4C20A91A.1080607@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 06/22/2010 03:14 PM, Alexander Graf wrote: > Avi Kivity wrote: > >> On 06/22/2010 03:10 PM, Alexander Graf wrote: >> >>> If you have more performance hints, I'll gladly take them :). >>> >>> >> Using a cpu that virtualizes the mmu in hardware helps tremendously. >> >> > PPC never does that. Even with the virtualization extensions the MMU is > still software managed. Then mmu intensive loads can expect to be slow. > I was also more thinking of hints like > "kmem_cache_zalloc is slow" or so ;). > Stuff like that is usually worthless. To give real feedback I need to understand the hardware, so I'm reduced to coding style and indentation review. -- error compiling committee.c: too many arguments to function