linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* UCC interactions
@ 2010-06-21 19:00 Gary Thomas
  2010-06-21 19:19 ` Steven Blakeslee
  2010-06-22 14:51 ` Timur Tabi
  0 siblings, 2 replies; 5+ messages in thread
From: Gary Thomas @ 2010-06-21 19:00 UTC (permalink / raw)
  To: Linux PPC Development

I'm running 2.6.33.3 on MPC8358.  I have UCC1+UCC2 working fine
for ethernet, but when I add UCC3 as a UART, the network devices
quit working.

Here are my device tree entries:
          /* ETH0 (UCC1, MDIO 0x02, RMII) */
          enet_eth0: ethernet@2000 {
             device_type = "network";
             compatible = "ucc_geth";
             cell-index = <1>;
             reg = <0x2000 0x200>;
             interrupts = <32>;
             interrupt-parent = <&qeic>;
             local-mac-address = [ 00 00 00 00 00 00 ];
             rx-clock-name = "none";
             tx-clock-name = "clk16";
             phy-handle = <&phy_eth0>;
             phy-connection-type = "rmii";
             pio-handle = <&pio_ucc1>;
             linux,network-index = <0>;
          };

          /* ETH1 (UCC2, MDIO 0x01, GMII) */
          enet_eth1: ethernet@3000 {
             device_type = "network";
             compatible = "ucc_geth";
             cell-index = <2>;
             reg = <0x3000 0x200>;
             interrupts = <33>;
             interrupt-parent = <&qeic>;
             local-mac-address = [ 00 00 00 00 00 00 ];
             rx-clock-name = "clk4";
             tx-clock-name = "none";
             fixed-link = <1 1 1000 0 0>;
             phy-connection-type = "gmii";
             pio-handle = <&pio_ucc2>;
             linux,network-index = <1>;
          };

          /* ttyQE0 (UCC3) */
          serial_qe0: serial@4000 {
             device_type = "serial";
             compatible = "ucc_uart";
             cell-index = <3>;
             reg = <0x4000 0x200>;
             interrupts = <34>;
             interrupt-parent = <&qeic>;
             port-number = <0>;
             rx-clock-name = "brg1";
             tx-clock-name = "brg1";
          };

Are there known interactions between these two drivers/ports?
Maybe there's something obviously wrong with my device tree?

Thanks for any ideas/pointers

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------

^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: UCC interactions
  2010-06-21 19:00 UCC interactions Gary Thomas
@ 2010-06-21 19:19 ` Steven Blakeslee
  2010-06-21 20:23   ` Gary Thomas
  2010-06-22 14:51 ` Timur Tabi
  1 sibling, 1 reply; 5+ messages in thread
From: Steven Blakeslee @ 2010-06-21 19:19 UTC (permalink / raw)
  To: Gary Thomas, Linux PPC Development

I believe the offset for UCC3 is wrong.  The usermanual says UCC3's
registers are at 0x2200-0x23FF.  0x4000 is SDMA.  Hope that helps.

> -----Original Message-----
> From:
linuxppc-dev-bounces+blakeslees=3Dembeddedplanet.com@lists.ozlabs.org
> [mailto:linuxppc-dev-
> bounces+blakeslees=3Dembeddedplanet.com@lists.ozlabs.org] On Behalf Of
Gary
> Thomas
> Sent: Monday, June 21, 2010 3:00 PM
> To: Linux PPC Development
> Subject: UCC interactions
>=20
> I'm running 2.6.33.3 on MPC8358.  I have UCC1+UCC2 working fine
> for ethernet, but when I add UCC3 as a UART, the network devices
> quit working.
>=20
> Here are my device tree entries:
>           /* ETH0 (UCC1, MDIO 0x02, RMII) */
>           enet_eth0: ethernet@2000 {
>              device_type =3D "network";
>              compatible =3D "ucc_geth";
>              cell-index =3D <1>;
>              reg =3D <0x2000 0x200>;
>              interrupts =3D <32>;
>              interrupt-parent =3D <&qeic>;
>              local-mac-address =3D [ 00 00 00 00 00 00 ];
>              rx-clock-name =3D "none";
>              tx-clock-name =3D "clk16";
>              phy-handle =3D <&phy_eth0>;
>              phy-connection-type =3D "rmii";
>              pio-handle =3D <&pio_ucc1>;
>              linux,network-index =3D <0>;
>           };
>=20
>           /* ETH1 (UCC2, MDIO 0x01, GMII) */
>           enet_eth1: ethernet@3000 {
>              device_type =3D "network";
>              compatible =3D "ucc_geth";
>              cell-index =3D <2>;
>              reg =3D <0x3000 0x200>;
>              interrupts =3D <33>;
>              interrupt-parent =3D <&qeic>;
>              local-mac-address =3D [ 00 00 00 00 00 00 ];
>              rx-clock-name =3D "clk4";
>              tx-clock-name =3D "none";
>              fixed-link =3D <1 1 1000 0 0>;
>              phy-connection-type =3D "gmii";
>              pio-handle =3D <&pio_ucc2>;
>              linux,network-index =3D <1>;
>           };
>=20
>           /* ttyQE0 (UCC3) */
>           serial_qe0: serial@4000 {
>              device_type =3D "serial";
>              compatible =3D "ucc_uart";
>              cell-index =3D <3>;
>              reg =3D <0x4000 0x200>;
>              interrupts =3D <34>;
>              interrupt-parent =3D <&qeic>;
>              port-number =3D <0>;
>              rx-clock-name =3D "brg1";
>              tx-clock-name =3D "brg1";
>           };
>=20
> Are there known interactions between these two drivers/ports?
> Maybe there's something obviously wrong with my device tree?
>=20
> Thanks for any ideas/pointers
>=20
> --
> ------------------------------------------------------------
> Gary Thomas                 |  Consulting for the
> MLB Associates              |    Embedded world
> ------------------------------------------------------------
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev

--
ExchangeDefender Message Security: Click below to verify authenticity
http://www.exchangedefender.com/verify.asp?id=3Do5LJJcQU009752&from=3Dblake=
slees@embeddedplanet.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: UCC interactions
  2010-06-21 19:19 ` Steven Blakeslee
@ 2010-06-21 20:23   ` Gary Thomas
  0 siblings, 0 replies; 5+ messages in thread
From: Gary Thomas @ 2010-06-21 20:23 UTC (permalink / raw)
  To: Steven Blakeslee; +Cc: Linux PPC Development

On 06/21/2010 01:19 PM, Steven Blakeslee wrote:
> I believe the offset for UCC3 is wrong.  The usermanual says UCC3's
> registers are at 0x2200-0x23FF.  0x4000 is SDMA.  Hope that helps.

Looks like that was it (not sure where I got that value from!)

Thanks

>> -----Original Message-----
>> From:
> linuxppc-dev-bounces+blakeslees=embeddedplanet.com@lists.ozlabs.org
>> [mailto:linuxppc-dev-
>> bounces+blakeslees=embeddedplanet.com@lists.ozlabs.org] On Behalf Of
> Gary
>> Thomas
>> Sent: Monday, June 21, 2010 3:00 PM
>> To: Linux PPC Development
>> Subject: UCC interactions
>>
>> I'm running 2.6.33.3 on MPC8358.  I have UCC1+UCC2 working fine
>> for ethernet, but when I add UCC3 as a UART, the network devices
>> quit working.
>>
>> Here are my device tree entries:
>>            /* ETH0 (UCC1, MDIO 0x02, RMII) */
>>            enet_eth0: ethernet@2000 {
>>               device_type = "network";
>>               compatible = "ucc_geth";
>>               cell-index =<1>;
>>               reg =<0x2000 0x200>;
>>               interrupts =<32>;
>>               interrupt-parent =<&qeic>;
>>               local-mac-address = [ 00 00 00 00 00 00 ];
>>               rx-clock-name = "none";
>>               tx-clock-name = "clk16";
>>               phy-handle =<&phy_eth0>;
>>               phy-connection-type = "rmii";
>>               pio-handle =<&pio_ucc1>;
>>               linux,network-index =<0>;
>>            };
>>
>>            /* ETH1 (UCC2, MDIO 0x01, GMII) */
>>            enet_eth1: ethernet@3000 {
>>               device_type = "network";
>>               compatible = "ucc_geth";
>>               cell-index =<2>;
>>               reg =<0x3000 0x200>;
>>               interrupts =<33>;
>>               interrupt-parent =<&qeic>;
>>               local-mac-address = [ 00 00 00 00 00 00 ];
>>               rx-clock-name = "clk4";
>>               tx-clock-name = "none";
>>               fixed-link =<1 1 1000 0 0>;
>>               phy-connection-type = "gmii";
>>               pio-handle =<&pio_ucc2>;
>>               linux,network-index =<1>;
>>            };
>>
>>            /* ttyQE0 (UCC3) */
>>            serial_qe0: serial@4000 {
>>               device_type = "serial";
>>               compatible = "ucc_uart";
>>               cell-index =<3>;
>>               reg =<0x4000 0x200>;
>>               interrupts =<34>;
>>               interrupt-parent =<&qeic>;
>>               port-number =<0>;
>>               rx-clock-name = "brg1";
>>               tx-clock-name = "brg1";
>>            };
>>
>> Are there known interactions between these two drivers/ports?
>> Maybe there's something obviously wrong with my device tree?
>>
>> Thanks for any ideas/pointers
>>
>> --
>> ------------------------------------------------------------
>> Gary Thomas                 |  Consulting for the
>> MLB Associates              |    Embedded world
>> ------------------------------------------------------------
>> _______________________________________________
>> Linuxppc-dev mailing list
>> Linuxppc-dev@lists.ozlabs.org
>> https://lists.ozlabs.org/listinfo/linuxppc-dev
>
> --
> ExchangeDefender Message Security: Click below to verify authenticity
> http://www.exchangedefender.com/verify.asp?id=o5LJJcQU009752&from=blakeslees@embeddedplanet.com

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: UCC interactions
  2010-06-21 19:00 UCC interactions Gary Thomas
  2010-06-21 19:19 ` Steven Blakeslee
@ 2010-06-22 14:51 ` Timur Tabi
  2010-06-22 15:15   ` Chuck Meade
  1 sibling, 1 reply; 5+ messages in thread
From: Timur Tabi @ 2010-06-22 14:51 UTC (permalink / raw)
  To: Gary Thomas; +Cc: Linux PPC Development

On Mon, Jun 21, 2010 at 2:00 PM, Gary Thomas <gary@mlbassoc.com> wrote:
> I'm running 2.6.33.3 on MPC8358. =A0I have UCC1+UCC2 working fine
> for ethernet, but when I add UCC3 as a UART, the network devices
> quit working.

Since you're using QE UART, would you mind testing this patch:

http://patchwork.ozlabs.org/patch/56181/

and letting us know if it works for you?

--=20
Timur Tabi
Linux kernel developer at Freescale

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: UCC interactions
  2010-06-22 14:51 ` Timur Tabi
@ 2010-06-22 15:15   ` Chuck Meade
  0 siblings, 0 replies; 5+ messages in thread
From: Chuck Meade @ 2010-06-22 15:15 UTC (permalink / raw)
  To: linuxppc-dev

On 06/22/2010 10:51 AM, Timur Tabi wrote:
> On Mon, Jun 21, 2010 at 2:00 PM, Gary Thomas <gary@mlbassoc.com> wrote:
>> I'm running 2.6.33.3 on MPC8358.  I have UCC1+UCC2 working fine
>> for ethernet, but when I add UCC3 as a UART, the network devices
>> quit working.
> 
> Since you're using QE UART, would you mind testing this patch:
> 
> http://patchwork.ozlabs.org/patch/56181/
> 
> and letting us know if it works for you?
> 

Hi Timur,

His UART is not working yet.  I am fine with him testing my patch (I hope he does),
just he still is working on getting his UART to work at all.  I think since he is
using MPC8358, he needs the soft UART mode microcode patch.

The patch that you mention above is one I wrote that affects how the UART close
operation handles being closed when buffered output is still present.  I fixed the
timeout so it closes in the correct amount of time.  Gary is not quite ready for
testing this yet.

Thanks,
Chuck

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2010-06-22 15:15 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-21 19:00 UCC interactions Gary Thomas
2010-06-21 19:19 ` Steven Blakeslee
2010-06-21 20:23   ` Gary Thomas
2010-06-22 14:51 ` Timur Tabi
2010-06-22 15:15   ` Chuck Meade

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).