From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from az33egw02.freescale.net (az33egw02.freescale.net [192.88.158.103]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "az33egw02.freescale.net", Issuer "Thawte Premium Server CA" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id 1EE3EB6F17 for ; Wed, 23 Jun 2010 07:39:42 +1000 (EST) Received: from de01smr02.am.mot.com (de01smr02.freescale.net [10.208.0.151]) by az33egw02.freescale.net (8.14.3/az33egw02) with ESMTP id o5MLdeal020793 for ; Tue, 22 Jun 2010 14:39:40 -0700 (MST) Received: from az33exm25.fsl.freescale.net (az33exm25.am.freescale.net [10.64.32.16]) by de01smr02.am.mot.com (8.13.1/8.13.0) with ESMTP id o5MLplYp004054 for ; Tue, 22 Jun 2010 16:51:47 -0500 (CDT) Message-ID: <4C212D9A.5020908@freescale.com> Date: Tue, 22 Jun 2010 16:39:38 -0500 From: Scott Wood MIME-Version: 1.0 To: Grant Likely Subject: Re: [PATCH 2/2] powerpc/mpc5121: add initial support for PDM360NG board References: <1272659448-23302-1-git-send-email-agust@denx.de> <1272659448-23302-2-git-send-email-agust@denx.de> <4BDEFB13.5060407@freescale.com> <4BF45A1F.70100@freescale.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Cc: Detlev Zundel , Markus Fischer , devicetree-discuss@lists.ozlabs.org, Michael Weiss , linuxppc-dev@ozlabs.org, Anatolij Gustschin , Wolfgang Grandegger List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 05/19/2010 04:47 PM, Grant Likely wrote: > On Wed, May 19, 2010 at 3:37 PM, Scott Wood wrote: >> I believe the only part of this that is new with ePAPR is that it asks that >> the interrupt controller address cells be explicitly specified, as it's a >> bit icky for it to default to 2 in some contexts and 0 in others. > > Hmmm. I've not seen that before. On the 5200 the value of > #address-cells for interrupt controllers has apparently defaulted to > <0> so I've never encountered or thought about it. I'm not even sure > what #address-cells != 0 would mean in the context of interrupt > mapping, or where it would be relevant. The address component is mainly used in PCI interrupt mapping, where each slot has a distinct wiring. It would be weird to see it on a normal interrupt controller, but explicitly setting it to zero helps avoid someone deciding that an interrupt controller ought to have a child node for whatever reason (this was an issue with MPIC), setting address cells to something non-zero, and messing up interrupt maps. -Scott