* [PATCH] kvm/ppc: fix build warning
@ 2010-06-24 19:44 Denis Kirjanov
2010-06-24 20:42 ` Alexander Graf
0 siblings, 1 reply; 5+ messages in thread
From: Denis Kirjanov @ 2010-06-24 19:44 UTC (permalink / raw)
To: agraf; +Cc: mtosatti, avi, kvm-ppc, linuxppc-dev
Fix build warning:
arch/powerpc/kvm/book3s_64_mmu.c: In function 'kvmppc_mmu_book3s_64_esid_to_vsid':
arch/powerpc/kvm/book3s_64_mmu.c:446: warning: 'slb' may be used uninitialized in this function
Signed-off-by: Denis Kirjanov <dkirjanov@kernel.org>
---
arch/powerpc/kvm/book3s_64_mmu.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/kvm/book3s_64_mmu.c b/arch/powerpc/kvm/book3s_64_mmu.c
index 4025ea2..61f2621 100644
--- a/arch/powerpc/kvm/book3s_64_mmu.c
+++ b/arch/powerpc/kvm/book3s_64_mmu.c
@@ -443,7 +443,7 @@ static int kvmppc_mmu_book3s_64_esid_to_vsid(struct kvm_vcpu *vcpu, ulong esid,
u64 *vsid)
{
ulong ea = esid << SID_SHIFT;
- struct kvmppc_slb *slb;
+ struct kvmppc_slb *uninitialized_var(slb);
u64 gvsid = esid;
if (vcpu->arch.msr & (MSR_DR|MSR_IR)) {
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] kvm/ppc: fix build warning
2010-06-24 19:44 [PATCH] kvm/ppc: fix build warning Denis Kirjanov
@ 2010-06-24 20:42 ` Alexander Graf
2010-06-25 9:02 ` Denis Kirjanov
0 siblings, 1 reply; 5+ messages in thread
From: Alexander Graf @ 2010-06-24 20:42 UTC (permalink / raw)
To: Denis Kirjanov; +Cc: mtosatti, avi, kvm-ppc, linuxppc-dev
On 24.06.2010, at 21:44, Denis Kirjanov wrote:
> Fix build warning:
> arch/powerpc/kvm/book3s_64_mmu.c: In function =
'kvmppc_mmu_book3s_64_esid_to_vsid':
> arch/powerpc/kvm/book3s_64_mmu.c:446: warning: 'slb' may be used =
uninitialized in this function
> Signed-off-by: Denis Kirjanov <dkirjanov@kernel.org>
Are you sure this isn't a broken compiler? I don't see where it could be =
used uninitialized.
Alex
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] kvm/ppc: fix build warning
2010-06-24 20:42 ` Alexander Graf
@ 2010-06-25 9:02 ` Denis Kirjanov
2010-06-25 9:21 ` Alexander Graf
2010-06-25 9:40 ` Denis Kirjanov
0 siblings, 2 replies; 5+ messages in thread
From: Denis Kirjanov @ 2010-06-25 9:02 UTC (permalink / raw)
To: Alexander Graf; +Cc: mtosatti, kvm-ppc, linuxppc-dev, Denis Kirjanov, avi
On 06/25/2010 12:42 AM, Alexander Graf wrote:
>
> On 24.06.2010, at 21:44, Denis Kirjanov wrote:
>
>> Fix build warning:
>> arch/powerpc/kvm/book3s_64_mmu.c: In function 'kvmppc_mmu_book3s_64_esid_to_vsid':
>> arch/powerpc/kvm/book3s_64_mmu.c:446: warning: 'slb' may be used uninitialized in this function
>> Signed-off-by: Denis Kirjanov<dkirjanov@kernel.org>
>
> Are you sure this isn't a broken compiler? I don't see where it could be used uninitialized.
I'm using gcc version 4.3.4 (Gentoo 4.3.4 p1.1, pie-10.1.5)
slb pointer initialized inside conditional branch
and used later in the case case MSR_DR|MSR_IR
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] kvm/ppc: fix build warning
2010-06-25 9:02 ` Denis Kirjanov
@ 2010-06-25 9:21 ` Alexander Graf
2010-06-25 9:40 ` Denis Kirjanov
1 sibling, 0 replies; 5+ messages in thread
From: Alexander Graf @ 2010-06-25 9:21 UTC (permalink / raw)
To: Denis Kirjanov; +Cc: mtosatti, kvm-ppc, linuxppc-dev, Denis Kirjanov, avi
On 25.06.2010, at 11:02, Denis Kirjanov wrote:
> On 06/25/2010 12:42 AM, Alexander Graf wrote:
>>=20
>> On 24.06.2010, at 21:44, Denis Kirjanov wrote:
>>=20
>>> Fix build warning:
>>> arch/powerpc/kvm/book3s_64_mmu.c: In function =
'kvmppc_mmu_book3s_64_esid_to_vsid':
>>> arch/powerpc/kvm/book3s_64_mmu.c:446: warning: 'slb' may be used =
uninitialized in this function
>>> Signed-off-by: Denis Kirjanov<dkirjanov@kernel.org>
>>=20
>> Are you sure this isn't a broken compiler? I don't see where it could =
be used uninitialized.
>=20
> I'm using gcc version 4.3.4 (Gentoo 4.3.4 p1.1, pie-10.1.5)
> slb pointer initialized inside conditional branch
> and used later in the case case MSR_DR|MSR_IR
>=20
Oh, I'm apparently looking at completely different code. The same =
function in git://git.kernel.org/pub/scm/virt/kvm/kvm.git is good. Which =
tree did you use?
Alex
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] kvm/ppc: fix build warning
2010-06-25 9:02 ` Denis Kirjanov
2010-06-25 9:21 ` Alexander Graf
@ 2010-06-25 9:40 ` Denis Kirjanov
1 sibling, 0 replies; 5+ messages in thread
From: Denis Kirjanov @ 2010-06-25 9:40 UTC (permalink / raw)
To: Alexander Graf; +Cc: mtosatti, kvm-ppc, linuxppc-dev, Denis Kirjanov, avi
On 06/25/2010 01:02 PM, Denis Kirjanov wrote:
> On 06/25/2010 12:42 AM, Alexander Graf wrote:
>>
>> On 24.06.2010, at 21:44, Denis Kirjanov wrote:
>>
>>> Fix build warning:
>>> arch/powerpc/kvm/book3s_64_mmu.c: In function
>>> 'kvmppc_mmu_book3s_64_esid_to_vsid':
>>> arch/powerpc/kvm/book3s_64_mmu.c:446: warning: 'slb' may be used
>>> uninitialized in this function
>>> Signed-off-by: Denis Kirjanov<dkirjanov@kernel.org>
>>
>> Are you sure this isn't a broken compiler? I don't see where it could
>> be used uninitialized.
>
> I'm using gcc version 4.3.4 (Gentoo 4.3.4 p1.1, pie-10.1.5)
> slb pointer initialized inside conditional branch
> and used later in the case case MSR_DR|MSR_IR
>
This is based on linux-next tree (-next-20100623)
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-06-25 9:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-24 19:44 [PATCH] kvm/ppc: fix build warning Denis Kirjanov
2010-06-24 20:42 ` Alexander Graf
2010-06-25 9:02 ` Denis Kirjanov
2010-06-25 9:21 ` Alexander Graf
2010-06-25 9:40 ` Denis Kirjanov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).