linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	KVM list <kvm@vger.kernel.org>,
	kvm-ppc@vger.kernel.org
Subject: Re: [PATCH] KVM: PPC: Add generic hpte management functions
Date: Tue, 29 Jun 2010 16:13:24 +0300	[thread overview]
Message-ID: <4C29F174.9020902@redhat.com> (raw)
In-Reply-To: <4C29EFCC.3030303@suse.de>

On 06/29/2010 04:06 PM, Alexander Graf wrote:
>
> Are we looking at the same link? Looks good to me there.
>
>    


We're probably looking at the same link but looking at different 
things.  I'm whining about

     static u64 f() {
         ...
     }

as opposed to the more sober

     static u64 f()
     {
         ...
     }

for f in [kvmppc_mmu_hash_pte, kvmppc_mmu_hash_vpte, 
kvmppc_mmu_hash_vpte_long].

-- 
error compiling committee.c: too many arguments to function

  reply	other threads:[~2010-06-29 13:13 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-25 23:16 [PATCH] Faster MMU lookups for Book3s Alexander Graf
2010-06-25 23:16 ` [PATCH] KVM: PPC: Add generic hpte management functions Alexander Graf
2010-06-25 23:18   ` Alexander Graf
2010-06-28  8:28   ` Avi Kivity
2010-06-28  8:55     ` Alexander Graf
2010-06-28  9:12       ` Avi Kivity
2010-06-28  9:27         ` Alexander Graf
2010-06-28  9:34           ` Avi Kivity
2010-06-28  9:55             ` Alexander Graf
2010-06-28 10:01               ` Avi Kivity
2010-06-28 13:25                 ` Alexander Graf
2010-06-28 13:30                   ` Avi Kivity
2010-06-28 13:32                     ` Alexander Graf
2010-06-29 12:56         ` Alexander Graf
2010-06-29 13:05           ` Avi Kivity
2010-06-29 13:06             ` Alexander Graf
2010-06-29 13:13               ` Avi Kivity [this message]
2010-06-25 23:16 ` [PATCH] KVM: PPC: Make use of hash based Shadow MMU Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C29F174.9020902@redhat.com \
    --to=avi@redhat.com \
    --cc=agraf@suse.de \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).