From: Timur Tabi <timur@freescale.com>
To: Matthew McClintock <msm@freescale.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc:prom Export device tree physical address via proc
Date: Tue, 13 Jul 2010 13:55:25 -0500 [thread overview]
Message-ID: <4C3CB69D.4060400@freescale.com> (raw)
In-Reply-To: <1279047011-28989-1-git-send-email-msm@freescale.com>
Matthew McClintock wrote:
> + if (prop)
> + prom_remove_property(node, prop);
> + prop = of_find_property(node, "linux,devietree-end", NULL);
Either the indentation is wrong, or you're missing some braces here.
> + if (prop)
> + prom_remove_property(node, prop);
> +
> + flat_dt_start = (unsigned long)virt_to_phys(initial_boot_params);
> + flat_dt_end = (unsigned long)virt_to_phys(initial_boot_params)
> + + initial_boot_params->totalsize;
I think these should be u64, not unsigned long, to ensure support for 64-bit
physical addresses.
next prev parent reply other threads:[~2010-07-13 19:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-13 18:50 [PATCH] powerpc:prom Export device tree physical address via proc Matthew McClintock
2010-07-13 18:55 ` Timur Tabi [this message]
2010-07-14 12:51 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3CB69D.4060400@freescale.com \
--to=timur@freescale.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=msm@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).