linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Ilya Yanok <yanok@emcraft.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: Wolfgang Denk <wd@denx.de>
Subject: Commit 3da34aa brakes MSI support on MPC8308 (possibly all MPC83xx) [REPOST]
Date: Fri, 23 Jul 2010 01:09:24 +0400	[thread overview]
Message-ID: <4C48B384.1020006@emcraft.com> (raw)

  Hi Kumar, Kim, Josh, everybody,

I hope to disturb you but I haven't got any reply for my first posting...

I've found that MSI work correctly with older kernels on my MPC8308RDB 
board and don't work with newer ones. After bisecting I've found that 
the source of the problem is commit 3da34aa:

commit 3da34aae03d498ee62f75aa7467de93cce3030fd
Author: Kumar Gala <galak@kernel.crashing.org>
Date:   Tue May 12 15:51:56 2009 -0500

     powerpc/fsl: Support unique MSI addresses per PCIe Root Complex

     Its feasible based on how the PCI address map is setup that the region
     of PCI address space used for MSIs differs for each PHB on the same 
SoC.

     Instead of assuming that the address mappes to CCSRBAR 1:1 we read
     PEXCSRBAR (BAR0) for the PHB that the given pci_dev is on.

     Signed-off-by: Kumar Gala <galak@kernel.crashing.org>

I can see BAR0 initialization for 85xx/86xx hardware but not for 83xx 
neigher in the kernel nor in U-Boot (that makes me think that all 83xx 
can be affected).
I'm not actually an PCI expert so I've just tried to write IMMR base 
address to the BAR0 register from the U-Boot to get the correct address 
but this doesn't help.
Please direct me how to init 83xx PCIE controller to make it compatible 
with this patch.

Kim, I think MPC8315E is affected too, could you please test it?

Thanks in advance.

Regards, Ilya.

             reply	other threads:[~2010-07-22 21:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-22 21:09 Ilya Yanok [this message]
2010-07-22 21:11 ` Commit 3da34aa brakes MSI support on MPC8308 (possibly all MPC83xx) [REPOST] Ilya Yanok
2010-08-05  7:01   ` Kumar Gala
2010-08-05  8:24     ` Ilya Yanok
2010-08-05 13:50       ` Kumar Gala
2010-07-29 21:20 ` Wolfgang Denk
2010-08-03 19:11   ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C48B384.1020006@emcraft.com \
    --to=yanok@emcraft.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=wd@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).